Make the kernel_copy tests more robust/concurrent. by vext01 · Pull Request #79375 · rust-lang/rust

vext01 · 2020-11-24T11:34:54Z

These tests write to the same filenames in /tmp and in some cases these files don't get cleaned up properly. This caused issues for us when different users run the tests on the same system, e.g.:

---- sys::unix::kernel_copy::tests::bench_file_to_file_copy stdout ----
thread 'sys::unix::kernel_copy::tests::bench_file_to_file_copy' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', library/std/src/sys/unix/kernel_copy/tests.rs:71:10
---- sys::unix::kernel_copy::tests::bench_file_to_socket_copy stdout ----
thread 'sys::unix::kernel_copy::tests::bench_file_to_socket_copy' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', library/std/src/sys/unix/kernel_copy/tests.rs💯10

Use std::sys_common::io__test::tmpdir() to solve this.

CC @the8472.

rust-highfive · 2020-11-24T11:34:57Z

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

vext01 · 2020-11-24T11:56:41Z

There's a typo in the commit message: issue -> issues. I can fix that just before bors.

the8472 · 2020-11-24T13:17:08Z

LGTM

vext01 · 2020-11-24T13:20:53Z

Can I force push to fix the typo?

the8472 · 2020-11-24T13:37:40Z

There's no policy against that. CI will check your commits again anway.

vext01 · 2020-11-24T13:43:07Z

Fixed.

vext01 · 2020-11-26T10:03:41Z

I guess @joshtriplett is busy. Is someone else able to start the merge? @the8472?

the8472 · 2020-11-26T11:44:14Z

I don't have the necessary permissions to do that. You'll have to wait. IME PRs may take a few weeks, depending on how busy team members are.

vext01 · 2020-12-02T14:27:21Z

Is anyone able to kick the merge off for this? @joshtriplett ?

Sorry to be so persistent, but this bug is frequently biting us in our CI pipeline :(

the8472 · 2020-12-02T23:11:18Z

In the meantime you might want to update the PR to also apply the tempdir changes to the test added by #79600

These tests write to the same filenames in /tmp and in some cases these files don't get cleaned up properly. This caused issues for us when different users run the tests on the same system, e.g.: ``` ---- sys::unix::kernel_copy::tests::bench_file_to_file_copy stdout ---- thread 'sys::unix::kernel_copy::tests::bench_file_to_file_copy' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', library/std/src/sys/unix/kernel_copy/tests.rs:71:10 ---- sys::unix::kernel_copy::tests::bench_file_to_socket_copy stdout ---- thread 'sys::unix::kernel_copy::tests::bench_file_to_socket_copy' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', library/std/src/sys/unix/kernel_copy/tests.rs:100:10 ``` Use `std::sys_common::io__test::tmpdir()` to solve this.

vext01 · 2020-12-03T13:50:32Z

done!

bjorn3 · 2020-12-10T20:20:35Z

@bors r+ rollup

I didn't previously approve it as I wasn't sure if this PR was in scope of the r+ rights I recently got, but I just got a confirmation that it is fine.

bors · 2020-12-10T20:20:37Z

📌 Commit 87c1fdb has been approved by bjorn3

Make the kernel_copy tests more robust/concurrent. These tests write to the same filenames in /tmp and in some cases these files don't get cleaned up properly. This caused issues for us when different users run the tests on the same system, e.g.: ``` ---- sys::unix::kernel_copy::tests::bench_file_to_file_copy stdout ---- thread 'sys::unix::kernel_copy::tests::bench_file_to_file_copy' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', library/std/src/sys/unix/kernel_copy/tests.rs:71:10 ---- sys::unix::kernel_copy::tests::bench_file_to_socket_copy stdout ---- thread 'sys::unix::kernel_copy::tests::bench_file_to_socket_copy' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', library/std/src/sys/unix/kernel_copy/tests.rs💯10 ``` Use `std::sys_common::io__test::tmpdir()` to solve this. CC `@the8472.`

Rollup of 11 pull requests Successful merges: - rust-lang#77027 (Improve documentation for `std::{f32,f64}::mul_add`) - rust-lang#79375 (Make the kernel_copy tests more robust/concurrent.) - rust-lang#79639 (Add long explanation for E0212) - rust-lang#79698 (Add tracking issue template for library features.) - rust-lang#79809 (Dogfood `str_split_once()`) - rust-lang#79851 (Clarify the 'default is only allowed on...' error) - rust-lang#79858 (Update const-fn doc in unstable-book) - rust-lang#79860 (Clarify that String::split_at takes a byte index.) - rust-lang#79871 (Fix small typo in `wrapping_shl` documentation) - rust-lang#79896 (Make search results tab and help button focusable with keyboard) - rust-lang#79917 (Use Symbol for inline asm register class names) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…20201211 So as to inherit: rust-lang/rust#79375

rust-highfive assigned joshtriplett Nov 24, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2020

vext01 mentioned this pull request Nov 24, 2020
sync upstream softdevteam/ykrustc#147
Merged

vext01 force-pushed the kernel-copy-temps branch from 562e91b to 562474aCompare November 24, 2020 13:39

vext01 mentioned this pull request Nov 27, 2020
Reflect changes in ykpack for querying a function's body flags. softdevteam/ykrustc#148
Merged

vext01 force-pushed the kernel-copy-temps branch from 562474a to 87c1fdbCompare December 3, 2020 13:50

vext01 mentioned this pull request Dec 10, 2020
Sync Upstream softdevteam/ykrustc#152
Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2020

Dylan-DPC-zz mentioned this pull request Dec 10, 2020
Rollup of 14 pull requests #79920
Closed

tmandry mentioned this pull request Dec 11, 2020
Rollup of 11 pull requests #79927
Merged

bors merged commit a8c19e1 into rust-lang:masterDec 11, 2020

rustbot added this to the 1.50.0 milestone Dec 11, 2020

vext01 deleted the kernel-copy-temps branch December 11, 2020 10:21

vext01 added a commit to vext01/ykrustc that referenced this pull request Dec 11, 2020
Merge branch 'master' ofhttps://github.com/rust-lang/rustinto sync-…
0314ddc
…20201211 So as to inherit: rust-lang/rust#79375

vext01 mentioned this pull request Dec 11, 2020
Sync upstream again. softdevteam/ykrustc#153
Merged

Uh oh!

Uh oh!

Conversation

vext01 commented Nov 24, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Nov 24, 2020

Uh oh!

vext01 commented Nov 24, 2020

Uh oh!

the8472 commented Nov 24, 2020

Uh oh!

vext01 commented Nov 24, 2020

Uh oh!

the8472 commented Nov 24, 2020

Uh oh!

vext01 commented Nov 24, 2020

Uh oh!

vext01 commented Nov 26, 2020

Uh oh!

the8472 commented Nov 26, 2020

Uh oh!

vext01 commented Dec 2, 2020

Uh oh!

the8472 commented Dec 2, 2020

Uh oh!

vext01 commented Dec 3, 2020

Uh oh!

bjorn3 commented Dec 10, 2020

Uh oh!

bors commented Dec 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vext01 commented Nov 24, 2020•
edited
Loading