Enable smart punctuation by camelid · Pull Request #79423 · rust-lang/rust

camelid · 2020-11-25T20:33:25Z

Closes#76690.

rust-highfive · 2020-11-25T20:33:29Z

r? @ollie27

(rust-highfive has picked a reviewer for you, use r? to override)

camelid · 2020-11-25T20:33:49Z

r? @GuillaumeGomez

camelid · 2020-11-25T20:37:43Z

Before

After

camelid · 2020-11-25T20:38:08Z

So much nicer :)

GuillaumeGomez · 2020-11-25T20:39:21Z

So much nicer :)

Sorry but I really don't like it. XD So the changes look good, but do we really want to have this?

cc @jyn514

camelid · 2020-11-25T20:41:17Z

What don't you like about it? I think it looks better and is easier to read, and it also will be more consistent with other docs that manually use smart punctuation characters. If we're going to be using a serifed font (which is what we use), I think it looks really weird to have non-smart punctuation.

camelid · 2020-11-25T20:42:07Z

Another sample:

Before

After

jyn514 · 2020-11-25T22:57:57Z

I don't have a strong preference one way or another, they look pretty similar to me. I do think it makes sense to use smart quotes if we're using serif fonts.

(For the next reviewer: the difference in the first example is for "Safe Rust can't cause undefined behavior", it took me a while to find it.)

camelid · 2020-11-26T04:30:32Z

(For the next reviewer: the difference in the first example is for "Safe Rust can't cause undefined behavior", it took me a while to find it.)

Actually there are two other places, both in the second paragraph from the top. There’s an apostrophe and an en dash.

GuillaumeGomez · 2020-11-26T09:38:57Z

Maybe some other from @rust-lang/docs-rs might have opinions in here?

Nemo157 · 2020-11-26T10:10:59Z

I like it, assuming there's very few false replacements the correct quote/apostrophes look much better to me.

The en-dash usage there is wrong though, that should be an em-dash:

but also unsafe fn—see below).

camelid · 2020-11-26T19:48:38Z

I like it, assuming there's very few false replacements the correct quote/apostrophes look much better to me.

🎉

The en-dash usage there is wrong though, that should be an em-dash:

Actually I believe it is correct. Two dashes triggers an en dash and three dashes triggers an em dash. And TMK “ – “ and “—“ are considered equivalent, just stylistic choices. (E.g. I read a book about typography that used en dashes surrounded by spaces just like these docs.)

GuillaumeGomez · 2020-11-26T19:53:38Z

Well, in case it's approved, please also add documentation about this in the rustdoc book then.

camelid · 2020-12-04T02:37:58Z

Actually, is it necessary to document this? It's purely a display thing -- e.g. we don't (TMK) have docs about the particular way search results are rendered.

jyn514 · 2020-12-04T04:58:09Z

Yeah I don't think we need to document this.

steveklabnik · 2020-12-04T19:44:03Z

Does this cause smart quotes in code blocks? It would be good to have a test for that case specifically so that if we change anything here, it doesn't regress in the future.

Actually, is it necessary to document this? It's purely a display thing -- e.g. we don't (TMK) have docs about the particular way search results are rendered.

IMHO, people who care about writing docs will care how they look. Documenting this seems important. For example, I would go actually put "real" em dashes in if I wasn't sure that the double hyphen wasn't guaranteed to turn into one.

jyn514 · 2021-02-06T22:32:39Z

What is this waiting on? I think smart quotes are a useful addition. @camelid can you update the documentation in src/doc/rustdoc/src/how-to-write-documentation.md?

GuillaumeGomez · 2021-02-06T22:49:59Z

@jyn514 It's waiting for confirmation on @steveklabnik's concern and for documentation to be added too.

EDIT: the ctrl+maj combo is a really bad habit...

Nemo157 · 2021-02-08T13:50:50Z

punct' is a short-hand for punctuation, so yes in this case it is normal.

camelid · 2021-02-08T17:52:16Z

Yeah, I try to exercise some edge cases in that test, so in the source I have an apostrophe followed by a double quote. There's no "triple quote" there :)

Apparently `"foo\""` has different behavior from `'foo\''` in Python shlex. See the [discussion on Zulip][z] for more. [z]: https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/.40has.20checks.20.22no.20closing.20quotation.22

camelid · 2021-02-19T23:11:53Z

This should be ready for merging or FCP if necessary.

jyn514 · 2021-02-21T18:06:10Z

@jyn514 It's waiting for confirmation on steveklabnik's concern and for documentation to be added too.

@camelid has since added a test for quotes in code-blocks: https://github.com/rust-lang/rust/pull/79423/files#diff-7a22adb112bf3fd5a130fbf12d52d123b5d1b00b9399d7cbce911a84c3dec50fR29
and added documentation for the feature.

@bors r+

bors · 2021-02-21T18:06:12Z

📌 Commit 1b29b29 has been approved by jyn514

Enable smart punctuation Closesrust-lang#76690.

Rollup of 12 pull requests Successful merges: - rust-lang#79423 (Enable smart punctuation) - rust-lang#81154 (Improve design of `assert_len`) - rust-lang#81235 (Improve suggestion for tuple struct pattern matching errors.) - rust-lang#81769 (Suggest `return`ing tail expressions that match return type) - rust-lang#81837 (Slight perf improvement on char::to_ascii_lowercase) - rust-lang#81969 (Avoid `cfg_if` in `std::os`) - rust-lang#81984 (Make WASI's `hard_link` behavior match other platforms.) - rust-lang#82091 (use PlaceRef abstractions more consistently) - rust-lang#82128 (add diagnostic items for OsString/PathBuf/Owned as well as to_vec on slice) - rust-lang#82166 (add s390x-unknown-linux-musl target) - rust-lang#82234 (Remove query parameters when skipping search results) - rust-lang#82255 (Make `treat_err_as_bug` Option<NonZeroUsize>) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

pthariensflame · 2021-04-06T10:58:38Z

Does this need relnotes for compatibility?

camelid · 2021-04-06T17:16:12Z

Compatibility with what? relnotes could make sense anyway though.

pthariensflame · 2021-04-06T17:58:44Z

I suppose I wasn’t thinking in specifics, but I guess we don’t guarantee that the output of rustdoc is stable to that degree. 🤷

camelid · 2021-04-06T18:00:00Z

Yeah, it's just a UI change. But it could be worth adding to relnotes to draw attention to it.

Package changes: * bump bootstraps to 1.51.0. * adjust patches and cargo checksums as required * 1.51 failed to build natively on 32-bit armv7, there is hope that this is fixed with 1.52. (1.51 can be built with netbsd32 emulation on a aarch64 system). Upsteream changes: Version 1.52.0 (2021-05-06) ============================ Language -------- - [Added the `unsafe_op_in_unsafe_fn` lint, which checks whether the unsafe code in an `unsafe fn` is wrapped in a `unsafe` block.][79208] This lint is allowed by default, and may become a warning or hard error in a future edition. - [You can now cast mutable references to arrays to a pointer of the same type as the element.][81479] Compiler -------- - [Upgraded the default LLVM to LLVM 12.][81451] Added tier 3\* support for the following targets. - [`s390x-unknown-linux-musl`][82166] - [`riscv32gc-unknown-linux-musl` & `riscv64gc-unknown-linux-musl`][82202] - [`powerpc-unknown-openbsd`][82733] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [`OsString` now implements `Extend` and `FromIterator`.][82121] - [`cmp::Reverse` now has `#[repr(transparent)]` representation.][81879] - [`Arc<impl Error>` now implements `error::Error`.][80553] - [All integer division and remainder operations are now `const`.][80962] Stabilised APIs ------------- - [`Arguments::as_str`] - [`char::MAX`] - [`char::REPLACEMENT_CHARACTER`] - [`char::UNICODE_VERSION`] - [`char::decode_utf16`] - [`char::from_digit`] - [`char::from_u32_unchecked`] - [`char::from_u32`] - [`slice::partition_point`] - [`str::rsplit_once`] - [`str::split_once`] The following previously stable APIs are now `const`. - [`char::len_utf8`] - [`char::len_utf16`] - [`char::to_ascii_uppercase`] - [`char::to_ascii_lowercase`] - [`char::eq_ignore_ascii_case`] - [`u8::to_ascii_uppercase`] - [`u8::to_ascii_lowercase`] - [`u8::eq_ignore_ascii_case`] Rustdoc ------- - [Rustdoc lints are now treated as a tool lint, meaning that lints are now prefixed with `rustdoc::` (e.g. `#[warn(rustdoc::non_autolinks)]`).][80527] Using the old style is still allowed, and will become a warning in a future release. - [Rustdoc now supports argument files.][82261] - [Rustdoc now generates smart punctuation for documentation.][79423] - [You can now use "task lists" in Rustdoc Markdown.][81766] E.g. ```markdown - [x] Complete - [ ] Todo ``` Misc ---- - [You can now pass multiple filters to tests.][81356] E.g. `cargo test -- foo bar` will run all tests that match `foo` and `bar`. - [Rustup now distributes PDB symbols for the `std` library on Windows, allowing you to see `std` symbols when debugging.][82218] Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Check the result cache before the DepGraph when ensuring queries][81855] - [Try fast_reject::simplify_type in coherence before doing full check][81744] - [Only store a LocalDefId in some HIR nodes][81611] - [Store HIR attributes in a side table][79519] Compatibility Notes ------------------- - [Cargo build scripts are now forbidden from setting `RUSTC_BOOTSTRAP`.] [cargo/9181] - [Removed support for the `x86_64-rumprun-netbsd` target.][82594] - [Deprecated the `x86_64-sun-solaris` target in favor of `x86_64-pc-solaris`.] [82216] - [Rustdoc now only accepts `,`, ` `, and `\t` as delimiters for specifying languages in code blocks.][78429] - [Rustc now catches more cases of `pub_use_of_private_extern_crate`][80763] - [Changes in how proc macros handle whitespace may lead to panics when used with older `proc-macro-hack` versions. A `cargo update` should be sufficient to fix this in all cases.][84136] [84136]: rust-lang/rust#84136 [80763]: rust-lang/rust#80763 [82166]: rust-lang/rust#82166 [82121]: rust-lang/rust#82121 [81879]: rust-lang/rust#81879 [82261]: rust-lang/rust#82261 [82218]: rust-lang/rust#82218 [82216]: rust-lang/rust#82216 [82202]: rust-lang/rust#82202 [81855]: rust-lang/rust#81855 [81766]: rust-lang/rust#81766 [81744]: rust-lang/rust#81744 [81611]: rust-lang/rust#81611 [81479]: rust-lang/rust#81479 [81451]: rust-lang/rust#81451 [81356]: rust-lang/rust#81356 [80962]: rust-lang/rust#80962 [80553]: rust-lang/rust#80553 [80527]: rust-lang/rust#80527 [79519]: rust-lang/rust#79519 [79423]: rust-lang/rust#79423 [79208]: rust-lang/rust#79208 [78429]: rust-lang/rust#78429 [82733]: rust-lang/rust#82733 [82594]: rust-lang/rust#82594 [cargo/9181]: rust-lang/cargo#9181 [`char::MAX`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.MAX [`char::REPLACEMENT_CHARACTER`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.REPLACEMENT_CHARACTER [`char::UNICODE_VERSION`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.UNICODE_VERSION [`char::decode_utf16`]: https://doc.rust-lang.org/std/primitive.char.html#method.decode_utf16 [`char::from_u32`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32 [`char::from_u32_unchecked`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32_unchecked [`char::from_digit`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_digit [`Peekable::next_if`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if [`Peekable::next_if_eq`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if_eq [`Arguments::as_str`]: https://doc.rust-lang.org/stable/std/fmt/struct.Arguments.html#method.as_str [`str::split_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_once [`str::rsplit_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.rsplit_once [`slice::partition_point`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.partition_point [`char::len_utf8`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf8 [`char::len_utf16`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf16 [`char::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_uppercase [`char::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_lowercase [`char::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.eq_ignore_ascii_case [`u8::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_uppercase [`u8::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_lowercase [`u8::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.eq_ignore_ascii_case

Pkgsrc changes: * Bump bootstrap kit version to 1.51.0. * Adjust patches as needed. * Update checksum adjustments. * Fix syntax error in commands adjusting libserde_derive for Darwin Upstream changes: Version 1.52.1 (2021-05-10) ============================ This release disables incremental compilation, unless the user has explicitly opted in via the newly added RUSTC_FORCE_INCREMENTAL=1 environment variable. This is due to the widespread, and frequently occuring, breakage encountered by Rust users due to newly enabled incremental verification in 1.52.0. Notably, Rust users **should** upgrade to 1.52.0 or 1.52.1: the bugs that are detected by newly added incremental verification are still present in past stable versions, and are not yet fixed on any channel. These bugs can lead to miscompilation of Rust binaries. These problems only affect incremental builds, so release builds with Cargo should not be affected unless the user has explicitly opted into incremental. Debug and check builds are affected. See [84970] for more details. [84970]: rust-lang/rust#84970 Version 1.52.0 (2021-05-06) ============================ Language -------- - [Added the `unsafe_op_in_unsafe_fn` lint, which checks whether the unsafe code in an `unsafe fn` is wrapped in a `unsafe` block.][79208] This lint is allowed by default, and may become a warning or hard error in a future edition. - [You can now cast mutable references to arrays to a pointer of the same type as the element.][81479] Compiler -------- - [Upgraded the default LLVM to LLVM 12.][81451] Added tier 3\* support for the following targets. - [`s390x-unknown-linux-musl`][82166] - [`riscv32gc-unknown-linux-musl` & `riscv64gc-unknown-linux-musl`][82202] - [`powerpc-unknown-openbsd`][82733] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [`OsString` now implements `Extend` and `FromIterator`.][82121] - [`cmp::Reverse` now has `#[repr(transparent)]` representation.][81879] - [`Arc<impl Error>` now implements `error::Error`.][80553] - [All integer division and remainder operations are now `const`.][80962] Stabilised APIs ------------- - [`Arguments::as_str`] - [`char::MAX`] - [`char::REPLACEMENT_CHARACTER`] - [`char::UNICODE_VERSION`] - [`char::decode_utf16`] - [`char::from_digit`] - [`char::from_u32_unchecked`] - [`char::from_u32`] - [`slice::partition_point`] - [`str::rsplit_once`] - [`str::split_once`] The following previously stable APIs are now `const`. - [`char::len_utf8`] - [`char::len_utf16`] - [`char::to_ascii_uppercase`] - [`char::to_ascii_lowercase`] - [`char::eq_ignore_ascii_case`] - [`u8::to_ascii_uppercase`] - [`u8::to_ascii_lowercase`] - [`u8::eq_ignore_ascii_case`] Rustdoc ------- - [Rustdoc lints are now treated as a tool lint, meaning that lints are now prefixed with `rustdoc::` (e.g. `#[warn(rustdoc::non_autolinks)]`).][80527] Using the old style is still allowed, and will become a warning in a future release. - [Rustdoc now supports argument files.][82261] - [Rustdoc now generates smart punctuation for documentation.][79423] - [You can now use "task lists" in Rustdoc Markdown.][81766] E.g. ```markdown - [x] Complete - [ ] Todo ``` Misc ---- - [You can now pass multiple filters to tests.][81356] E.g. `cargo test -- foo bar` will run all tests that match `foo` and `bar`. - [Rustup now distributes PDB symbols for the `std` library on Windows, allowing you to see `std` symbols when debugging.][82218] Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Check the result cache before the DepGraph when ensuring queries][81855] - [Try fast_reject::simplify_type in coherence before doing full check][81744] - [Only store a LocalDefId in some HIR nodes][81611] - [Store HIR attributes in a side table][79519] Compatibility Notes ------------------- - [Cargo build scripts are now forbidden from setting `RUSTC_BOOTSTRAP`.][cargo/9181] - [Removed support for the `x86_64-rumprun-netbsd` target.][82594] - [Deprecated the `x86_64-sun-solaris` target in favor of `x86_64-pc-solaris`.][82216] - [Rustdoc now only accepts `,`, ` `, and `\t` as delimiters for specifying languages in code blocks.][78429] - [Rustc now catches more cases of `pub_use_of_private_extern_crate`][80763] - [Changes in how proc macros handle whitespace may lead to panics when used with older `proc-macro-hack` versions. A `cargo update` should be sufficient to fix this in all cases.][84136] [84136]: rust-lang/rust#84136 [80763]: rust-lang/rust#80763 [82166]: rust-lang/rust#82166 [82121]: rust-lang/rust#82121 [81879]: rust-lang/rust#81879 [82261]: rust-lang/rust#82261 [82218]: rust-lang/rust#82218 [82216]: rust-lang/rust#82216 [82202]: rust-lang/rust#82202 [81855]: rust-lang/rust#81855 [81766]: rust-lang/rust#81766 [81744]: rust-lang/rust#81744 [81611]: rust-lang/rust#81611 [81479]: rust-lang/rust#81479 [81451]: rust-lang/rust#81451 [81356]: rust-lang/rust#81356 [80962]: rust-lang/rust#80962 [80553]: rust-lang/rust#80553 [80527]: rust-lang/rust#80527 [79519]: rust-lang/rust#79519 [79423]: rust-lang/rust#79423 [79208]: rust-lang/rust#79208 [78429]: rust-lang/rust#78429 [82733]: rust-lang/rust#82733 [82594]: rust-lang/rust#82594 [cargo/9181]: rust-lang/cargo#9181 [`char::MAX`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.MAX [`char::REPLACEMENT_CHARACTER`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.REPLACEMENT_CHARACTER [`char::UNICODE_VERSION`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.UNICODE_VERSION [`char::decode_utf16`]: https://doc.rust-lang.org/std/primitive.char.html#method.decode_utf16 [`char::from_u32`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32 [`char::from_u32_unchecked`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32_unchecked [`char::from_digit`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_digit [`Peekable::next_if`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if [`Peekable::next_if_eq`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if_eq [`Arguments::as_str`]: https://doc.rust-lang.org/stable/std/fmt/struct.Arguments.html#method.as_str [`str::split_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_once [`str::rsplit_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.rsplit_once [`slice::partition_point`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.partition_point [`char::len_utf8`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf8 [`char::len_utf16`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf16 [`char::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_uppercase [`char::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_lowercase [`char::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.eq_ignore_ascii_case [`u8::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_uppercase [`u8::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_lowercase [`u8::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.eq_ignore_ascii_case

camelid added A-markdown-parsing Area: Markdown parsing for doc-comments C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 25, 2020

rust-highfive assigned ollie27 Nov 25, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2020

rust-highfive assigned GuillaumeGomez and unassigned ollie27 Nov 25, 2020

camelid added the I-needs-decision Issue: In need of a decision. label Dec 4, 2020

camelid added the S-waiting-on-team label Jan 15, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2021

This comment has been minimized.
Sign in to view

Fix @has checks "no closing quotation" error
0a34521
Apparently `"foo\""` has different behavior from `'foo\''` in Python shlex. See the [discussion on Zulip][z] for more. [z]: https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/.40has.20checks.20.22no.20closing.20quotation.22

This comment has been minimized.
Sign in to view

Update Markdown unit tests
1b29b29

camelid force-pushed the smart-punct branch from cdb4933 to 1b29b29Compare February 9, 2021 20:25

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2021

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 22, 2021
Rollup merge ofrust-lang#79423- camelid:smart-punct, r=jyn514
89e2f77
Enable smart punctuation Closesrust-lang#76690.

GuillaumeGomez mentioned this pull request Feb 22, 2021
Rollup of 6 pull requests #82414
Closed

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 23, 2021
Rollup merge ofrust-lang#79423- camelid:smart-punct, r=jyn514
19489ae
Enable smart punctuation Closesrust-lang#76690.

This was referenced Feb 23, 2021
Rollup of 11 pull requests #82426
Closed
Rollup of 12 pull requests #82430
Merged

bors merged commit 1c2a949 into rust-lang:masterFeb 23, 2021

rustbot added this to the 1.52.0 milestone Feb 23, 2021

camelid deleted the smart-punct branch February 24, 2021 04:51

camelid added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 6, 2021

Uh oh!

Uh oh!

Conversation

camelid commented Nov 25, 2020

Uh oh!

rust-highfive commented Nov 25, 2020

Uh oh!

camelid commented Nov 25, 2020

Uh oh!

camelid commented Nov 25, 2020

Before

After

Uh oh!

camelid commented Nov 25, 2020

Uh oh!

GuillaumeGomez commented Nov 25, 2020

Uh oh!

camelid commented Nov 25, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camelid commented Nov 25, 2020

Before

After

Uh oh!

jyn514 commented Nov 25, 2020

Uh oh!

camelid commented Nov 26, 2020

Uh oh!

GuillaumeGomez commented Nov 26, 2020

Uh oh!

Nemo157 commented Nov 26, 2020

Uh oh!

camelid commented Nov 26, 2020

Uh oh!

GuillaumeGomez commented Nov 26, 2020

Uh oh!

camelid commented Dec 4, 2020

Uh oh!

jyn514 commented Dec 4, 2020

Uh oh!

steveklabnik commented Dec 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

jyn514 commented Feb 6, 2021

Uh oh!

GuillaumeGomez commented Feb 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nemo157 commented Feb 8, 2021

Uh oh!

camelid commented Feb 8, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

camelid commented Feb 19, 2021

Uh oh!

jyn514 commented Feb 21, 2021

Uh oh!

bors commented Feb 21, 2021

Uh oh!

pthariensflame commented Apr 6, 2021

Uh oh!

camelid commented Apr 6, 2021

Uh oh!

pthariensflame commented Apr 6, 2021

Uh oh!

camelid commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

camelid commented Nov 25, 2020•
edited
Loading

steveklabnik commented Dec 4, 2020•
edited
Loading

GuillaumeGomez commented Feb 6, 2021•
edited
Loading

camelid commented Apr 6, 2021•
edited
Loading