Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #79515
Closed
GuillaumeGomez wants to merge 13 commits into
Closed
Conversation
…jyn514 Rename "stability" CSS class to "item-info" and combine `document_stability` with `document_short` Follow-up of rust-lang#79300 The point of this PR is to make the CSS class more accurate since it's not only about stability anymore. r? `@jyn514`
…ark-Simulacrum BTreeMap: try to enhance various comments All in internal documentation, propagating the "key-value pair" notation from public documentation. r? `@Mark-Simulacrum`
…rror-output, r=jyn514
Improve rustdoc JS tests error output
It's pretty common when starting to add new tests for rustdoc-js to have issues to understand the errors. With this, it should make things a bit simpler. So now, in case of an error, it displays:
```
---- [js-doc-test] rustdoc-js/basic.rs stdout ----
error: rustdoc-js test failed!
failed to decode compiler output as json: line: {
output: Checking "basic" ... FAILED
==> Result not found in 'others': '{"path":"basic","name":"Fo"}'
Diff of first error:
{
"path": "basic",
- "name": "Fo",
+ "name": "Foo",
}
thread '[js-doc-test] rustdoc-js/basic.rs' panicked at 'explicit panic', src/tools/compiletest/src/json.rs:126:21
```
I think it was `@camelid` who asked about it a few days ago?
r? `@jyn514`…=jyn514 Extend doc keyword feature by allowing any ident Part of rust-lang#51315. As suggested by `@danielhenrymantilla` in [this comment](rust-lang#51315 (comment)), this PR extends `#[doc(keyword = "...")]` to allow any ident to be used as keyword. The final goal is to allow (proc-)macro crates' owners to write documentation of the keywords they might introduce. r? `@jyn514`
Cleanup: shorter and faster code
GuillaumeGomez
commented
Nov 28, 2020
MemberAuthor
@bors: r+ p=5 |
bors
commented
Nov 28, 2020
Collaborator
📌 Commit 427cdef has been approved by |
bors
commented
Nov 28, 2020
Collaborator
⌛ Testing commit 427cdef with merge 36e12fa7cf9e89944c5c1ddfbf71216989824d9e... |
bors
commented
Nov 28, 2020
Collaborator
💔 Test failed - checks-actions |
GuillaumeGomez
commented
Nov 29, 2020
MemberAuthor
@bors: retry |
bors
commented
Nov 29, 2020
Collaborator
⌛ Testing commit 427cdef with merge 3f678de27cde83ec8af56d5f998abda95471f17f... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
document_stabilitywithdocument_short#79340 (Rename "stability" CSS class to "item-info" and combinedocument_stabilitywithdocument_short)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup