Uh oh!
There was an error while loading. Please reload this page.
Make sure rust-call errors occur correctly for traits - #79675
Merged
Conversation
rust-highfive
commented
Dec 3, 2020
Contributor
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
CraftSpider
marked this pull request as ready for review
December 4, 2020 01:52
CraftSpider
commented
Dec 15, 2020
ContributorAuthor
@estebank are you available to review this? Apologies if you're busy |
jyn514
commented
Jan 8, 2021
Member
r? @oli-obk |
estebank
commented
Jan 8, 2021
Contributor
@CraftSpider apologies for the delay. I spent the entirety of December offline, which is why I didn't review this (and the triaging team doesn't pick these up earlier because some weeks have to pass before then). Looking at this now. |
estebank
commented
Jan 8, 2021
Contributor
bors
commented
Jan 8, 2021
Collaborator
📌 Commit d41122a has been approved by |
camelid
commented
Jan 8, 2021
Member
Also, wg-triage is on break until next week :) |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#79675 (Make sure rust-call errors occur correctly for traits) - rust-lang#80372 (Don't panic when an external crate can't be resolved) - rust-lang#80761 (handle generic trait methods in coverage-report tests) - rust-lang#80785 (rustc_ast_pretty: Remove `PrintState::insert_extra_parens`) - rust-lang#80791 (Fix type name in doc example for Iter and IterMut) - rust-lang#80794 (Use Option::map_or instead of `.map(..).unwrap_or(..)`) - rust-lang#80799 (Get rid of custom pretty-printing in rustdoc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
apiraino
commented
Jan 14, 2021
Contributor
beta backport has been declined. Zulip discussion from the compiler team at this link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#79669
Adds trait method resolution to the error, and adds UI tests to ensure it doesn't happen again. Opening as draft because I'm getting weird link errors from unrelated code on my machine, and want to see what CI thinks.