Uh oh!
There was an error while loading. Please reload this page.
Change 'print(fmt!(...))' to printf!/printfln! - #7968
Closed
poiru wants to merge 2 commits into
Closed
Conversation
thestinger
commented
Jul 24, 2013
Contributor
Landing as part of #7982. |
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 23, 2021
Fix `manual_map` with unsafe functions fixes: rust-lang#7820 changelog: Fix `manual_map` suggestion when used with unsafe functions and unsafe blocks
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
7969: Return original text range in PrepareRename responses when inside macro r=Veykril a=Veykril bors r+ Issue found in rust-lang#7968 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
print(fmt!(...))andprintln(fmt!(...))toprintf!(...)andprintfln!(...). This also removes the format strings in places where it is"%?". Others cases, such as"%s"can be removed, too, but perhaps those are best left for another PR.