Skip to content

Don't look for blanket impls in intra-doc links - #79682

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:no-blanket-impls
Dec 16, 2020
Merged

Don't look for blanket impls in intra-doc links#79682
bors merged 1 commit into
rust-lang:masterfrom
jyn514:no-blanket-impls

Conversation

@jyn514

@jyn514jyn514 commented Dec 4, 2020

Copy link
Copy Markdown
Member

This never worked and has been causing severe performance problems.
Hopefully it will be re-landed at some point in the future when it
actually works, but in the meantime it makes no sense to have the code
around when it does nothing and actively makes rustdoc harder to use.

Closes#78761. Does not affect #78800.

r? @Manishearth
cc @seeplusplus

@jyn514jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name labels Dec 4, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2020
jyn514
jyn514 commented Dec 4, 2020
View reviewed changes
Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
@jyn514jyn514 added the I-compiletime Issue: Problems and improvements with respect to compile times. label Dec 4, 2020
@jyn514

jyn514 commented Dec 4, 2020

Copy link
Copy Markdown
MemberAuthor

I'm testing locally that this actually improves the compile times for #78761.

@jyn514

jyn514 commented Dec 4, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Yup, this brought intra-doc links down to only 1.5 seconds 🎉 (down from 90 seconds).

@bors

This comment has been minimized.

Sign in to view
@bors

bors commented Dec 15, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #80044) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@jyn514
Don't look for blanket impls in intra-doc links
6580f11
This never worked and has been causing severe performance problems.
Hopefully it will be re-landed at some point in the future when it
actually works, but in the meantime it makes no sense to have the code
around when it does nothing and actively makes rustdoc harder to use.
@jyn514

jyn514 commented Dec 15, 2020

Copy link
Copy Markdown
MemberAuthor

@bors r=Manishearth,GuillaumeGomez

@bors

bors commented Dec 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 6580f11 has been approved by Manishearth,GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2020
@bors

bors commented Dec 16, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6580f11 with merge 268cbfe...

@bors

bors commented Dec 16, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Manishearth,GuillaumeGomez
Pushing 268cbfe to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Dec 16, 2020
@bors
bors merged commit 268cbfe into rust-lang:masterDec 16, 2020
@rustbotrustbot added this to the 1.50.0 milestone Dec 16, 2020
@jyn514
jyn514 deleted the no-blanket-impls branch December 16, 2020 13:10
@jyn514jyn514 added the relnotes-perf Performance improvements that should be mentioned in the release notes. label Jan 10, 2021
@bugadanibugadani mentioned this pull request Jan 15, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes
+1 more reviewer
@XanewokXanewokXanewok left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ManishearthManishearth

Labels

A-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by nameI-compiletimeIssue: Problems and improvements with respect to compile times.merged-by-borsThis PR was explicitly merged by bors.relnotes-perfPerformance improvements that should be mentioned in the release notes.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

Almost half the time rustdoc spends on stm32h7xx-hal is in intra-doc links

7 participants

@jyn514@rust-highfive@bors@GuillaumeGomez@Xanewok@Manishearth@rustbot