Skip to content

Update stdarch submodule - #79938

Merged
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:stdarch
Dec 15, 2020
Merged

Update stdarch submodule#79938
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:stdarch

Conversation

@tmiasko

@tmiaskotmiasko commented Dec 11, 2020

Copy link
Copy Markdown
Contributor

Changes included:

  • Use a bootstrap guard for modules with new target features
  • Avoid calling intrinsics with invalid const arguments
  • Avx512bw
  • Avx512cd
  • Add AVX512BITALG
  • Add GFNI Intrinsics
  • Add AVX512VPOPCNTDQ Intrinsics
  • Add VPCLMULQDQ Intrinsics
  • Avx512bw
  • Reimplement _xgetbv with LLVM intrinsics
  • Avx512bw
  • Add reamained vmax and vmin via auto-generated code
  • Add VAES intrinsics

Fixes#56483.

@tmiasko

tmiasko commented Dec 11, 2020

Copy link
Copy Markdown
ContributorAuthor

@bors rollup=never (due to potential impact on build times).

r? @Amanieu

@bors

bors commented Dec 11, 2020

Copy link
Copy Markdown
Collaborator

@tmiasko: 🔑 Insufficient privileges: not in try users

@Amanieu

Amanieu commented Dec 11, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Dec 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 5ba7e99 has been approved by Amanieu

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 11, 2020
@bors

bors commented Dec 12, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ba7e99 with merge 0cc990783371f7102893a9b00a2a56e951d35f19...

@bors

bors commented Dec 12, 2020

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 12, 2020
@Amanieu

Amanieu commented Dec 12, 2020

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 12, 2020
@Dylan-DPC
Rollup merge ofrust-lang#79938- tmiasko:stdarch, r=Amanieu
90da048
Update stdarch submodule
Changes included:
* Use a bootstrap guard for modules with new target features
* Avoid calling intrinsics with invalid const arguments
* Avx512bw
* Avx512cd
* Add AVX512BITALG
* Add GFNI Intrinsics
* Add AVX512VPOPCNTDQ Intrinsics
* Add VPCLMULQDQ Intrinsics
* Avx512bw
* Reimplement `_xgetbv` with LLVM intrinsics
* Avx512bw
* Add reamained vmax and vmin via auto-generated code
* Add VAES intrinsics
Fixesrust-lang#56483.
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Dec 12, 2020
Closed
@bors

bors commented Dec 13, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ba7e99 with merge 4a8ae56dc22c6660f2109aaf62ef0c31e1ecfca8...

@bors

bors commented Dec 13, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 13, 2020
@tmiasko

tmiasko commented Dec 14, 2020

Copy link
Copy Markdown
ContributorAuthor

Spurious failure:

LINK : fatal error LNK1201: error writing to program database 'D:\a\rust\rust\build\i686-pc-windows-msvc\test\run-make-fulldeps\override-aliased-flags\override-aliased-flags\main.pdb'; check for insufficient disk space, invalid path, or insufficient privilege

@Amanieu

Amanieu commented Dec 14, 2020

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2020
@bors

bors commented Dec 14, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ba7e99 with merge 8b3ee82...

@bors

bors commented Dec 15, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 8b3ee82 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Dec 15, 2020
@bors
bors merged commit 8b3ee82 into rust-lang:masterDec 15, 2020
@rustbotrustbot added this to the 1.50.0 milestone Dec 15, 2020
@tmiasko
tmiasko deleted the stdarch branch December 15, 2020 00:49
@rylev

rylev commented Dec 15, 2020•
edited
Loading

Copy link
Copy Markdown
Member

@tmiasko@Amanieu This change caused [lots of regressions in the perf benchmark. We should look into this to see if we can win some of the performance losses back. Most the perf losses seem to be in doc builds.

@camelidcamelid mentioned this pull request Dec 20, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@AmanieuAmanieu

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

LLVM assertion in simdnoise crate

5 participants

@tmiasko@bors@Amanieu@rylev@rustbot