Uh oh!
There was an error while loading. Please reload this page.
Improve core::ptr::drop_in_place debuginfo - #79968
Merged
Merged
Conversation
rust-highfive
commented
Dec 12, 2020
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
bjorn3force-pushed
the
better_drop_glue_debuginfo
branch
4 times, most recently
from
December 12, 2020 17:22
d4e05fb to
287b37eComparebjorn3force-pushed
the
better_drop_glue_debuginfo
branch
4 times, most recently
from
December 12, 2020 18:31
6b9a634 to
b51f539Comparenagisa
reviewed
Dec 14, 2020
Uh oh!
There was an error while loading. Please reload this page.
nagisa
reviewed
Dec 14, 2020
Uh oh!
There was an error while loading. Please reload this page.
bjorn3force-pushed
the
better_drop_glue_debuginfo
branch
from
December 17, 2020 08:59
0102ffa to
7cd049dCompare
This comment has been minimized.
This comment has been minimized.
bjorn3force-pushed
the
better_drop_glue_debuginfo
branch
from
December 17, 2020 09:07
7cd049d to
4a48d68Comparematthewjasper
commented
Jan 9, 2021
Contributor
@bors r+ |
bors
commented
Jan 9, 2021
Collaborator
📌 Commit 4a48d68 has been approved by |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 10, 2021
…r=matthewjasper
Improve core::ptr::drop_in_place debuginfo
* Use span of the dropped type as function span when possible.
* Rename symbol from `core::ptr::drop_in_place::$hash` to `{{drop}}::<$TYPE>::$hash`.
Fixesrust-lang#77465
(I haven't yet updated the tests)
This was referenced Jan 10, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 10, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#79502 (Implement From<char> for u64 and u128.) - rust-lang#79968 (Improve core::ptr::drop_in_place debuginfo) - rust-lang#80774 (Fix safety comment) - rust-lang#80801 (Use correct span for structured suggestion) - rust-lang#80803 (Remove useless `fill_in` function) - rust-lang#80820 (Support `download-ci-llvm` on NixOS) - rust-lang#80825 (Remove under-used ImplPolarity enum) - rust-lang#80850 (Allow #[rustc_builtin_macro = "name"]) - rust-lang#80857 (Add comment to `Vec::truncate` explaining `>` vs `>=`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
rylev
commented
Jan 14, 2021
Member
This PR introduced a moderate performance regression which you can learn more about here #80947. We've decided that the regression is worth it in this case for the better debugging output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core::ptr::drop_in_place::$hashto{{drop}}::<$TYPE>::$hash.Fixes#77465
(I haven't yet updated the tests)