Skip to content

ToStr for HashMap does not need value to implement Eq or Hash - #7998

Closed
stepancheg wants to merge 1 commit into
rust-lang:masterfrom
stepancheg:hash_map_to_str
Closed

ToStr for HashMap does not need value to implement Eq or Hash#7998
stepancheg wants to merge 1 commit into
rust-lang:masterfrom
stepancheg:hash_map_to_str

Conversation

@stepancheg

Copy link
Copy Markdown
Contributor

No description provided.

@stepancheg

Copy link
Copy Markdown
ContributorAuthor

Renamed StructWithStrWithoutEqOrHash -> StructWithToStrWithoutEqOrHash.

When I did git push -f, github dropped comments.

@cmr asked whether ToStr implementation for HashMap needs Eq and Hash for key. I replied that Eq and Hash are currently used in implementation of HashMap::iter().

@thestinger

Copy link
Copy Markdown
Contributor

Landing as part of #7982.

U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
7998: Use more Chalk IDs r=flodiebold a=flodiebold
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stepancheg@thestinger@emberian