Uh oh!
There was an error while loading. Please reload this page.
Fixes submit event of the search input - #79985
Merged
Merged
Conversation
camelid
reviewed
Dec 12, 2020
Uh oh!
There was an error while loading. Please reload this page.
camelid
reviewed
Dec 12, 2020
Uh oh!
There was an error while loading. Please reload this page.
In HTML, when a button follows an input, if the enter keep is pressed on the input, instead of sending the submit event to the input, it'll create a click event on the button following it, which in this case made the help popup show up whenever "enter" was pressed.
GuillaumeGomezforce-pushed
the
fix-submit-event
branch
from
December 12, 2020 23:25
551aa10 to
98118bbCompareGuillaumeGomez
commented
Dec 12, 2020
MemberAuthor
Switched back to button! |
jyn514
commented
Dec 12, 2020
Member
r=me with CI passing |
jyn514
commented
Dec 12, 2020
Member
Oh wait, there are no tests for the frontend :( @bors r+ rollup |
bors
commented
Dec 12, 2020
Collaborator
📌 Commit 98118bb has been approved by |
GuillaumeGomez
commented
Dec 12, 2020
via email
MemberAuthor
Not yet you mean! :p
Le dim. 13 déc. 2020 à 00:40, bors <notifications@github.com> a écrit : … 📌 Commit 98118bb
<98118bb>
has been approved by jyn514
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#79985 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXIUTFGKO6ORYOX3EDBZPLSUP5OJANCNFSM4UYXLN3A>
.
|
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2020
Rollup of 12 pull requests Successful merges: - rust-lang#79360 (std::iter: document iteration over `&T` and `&mut T`) - rust-lang#79398 (Link loop/for keyword) - rust-lang#79834 (Remove deprecated linked_list_extras methods.) - rust-lang#79845 (Fix rustup support in default_build_triple for python3) - rust-lang#79940 (fix more clippy::complexity findings) - rust-lang#79942 (Add post-init hook for static memory for miri.) - rust-lang#79954 (Fix building compiler docs with stage 0) - rust-lang#79963 (Fix typo in `DebruijnIndex` documentation) - rust-lang#79970 (Misc rustbuild improvements when the LLVM backend isn't used) - rust-lang#79973 (rustdoc light theme: Fix CSS for selected buttons) - rust-lang#79984 (Remove an unused dependency that made `rustdoc` crash) - rust-lang#79985 (Fixes submit event of the search input) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 18, 2021
…ed, r=Nemo157 Only build help popup when it's really needed When working on rust-lang#79985, I realized that the help popup was built even when it wasn't needed. This PR only makes the help popup to be built when required. r? `@jyn514`
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 19, 2021
…ed, r=Nemo157 Only build help popup when it's really needed When working on rust-lang#79985, I realized that the help popup was built even when it wasn't needed. This PR only makes the help popup to be built when required. r? `@jyn514`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#79960
It's a very funny corner case:
In HTML, when a button follows an input (in a
form), if the enter keep is pressed on the input, instead of sending the submit event to the input, it'll create a click event on the button following it, which in this case made the help popup show up whenever "enter" was pressed.cc @camelid
r? @jyn514