Uh oh!
There was an error while loading. Please reload this page.
Get rid of clean::Deprecation - #80041
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This brings the size of `item.deprecation` from 56 to 16 bytes.
jyn514
commented
Dec 15, 2020
@bors try @rust-timer queue |
rust-timer
commented
Dec 15, 2020
Awaiting bors try build completion |
bors
commented
Dec 15, 2020
⌛ Trying commit 7d45243 with merge b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f... |
bors
commented
Dec 15, 2020
☀️ Try build successful - checks-actions |
rust-timer
commented
Dec 15, 2020
Queued b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f with parent 8b3ee82, future comparison URL. |
rust-timer
commented
Dec 15, 2020
Finished benchmarking try commit (b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
jyn514
commented
Dec 15, 2020
The changes in instruction counts are marginal, but -.5% on max-rss. I think this is worth landing just for the cleanup honestly. |
GuillaumeGomez
commented
Dec 15, 2020
Just the fact that it removes code makes it worth it. 😄 @bors: r+ |
bors
commented
Dec 15, 2020
📌 Commit 7d45243 has been approved by |
bors
commented
Dec 15, 2020
⌛ Testing commit 7d45243 with merge 0298b3901dd66b407dfb15352c06e83bea0eecb4... |
bors
commented
Dec 15, 2020
💔 Test failed - checks-actions |
rust-log-analyzer
commented
Dec 15, 2020
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The dist-x86_64-apple job failed, but there's no build log to see why :/ @rust-lang/infra do you know what's going wrong here? @bors retry |
bors
commented
Dec 16, 2020
bors
commented
Dec 16, 2020
☀️ Test successful - checks-actions |
emilyalbini
commented
Dec 16, 2020
Not having logs usually happens when the machine is disconnected from the network / crashes. My guess is that's probably https://www.githubstatus.com/incidents/3jr0nb7zjpbm. |
This brings the size of
item.deprecationfrom 56 to 16 bytes. Helps with #79103 and #76382, in the same vein as #79957.r? @GuillaumeGomez