Uh oh!
There was an error while loading. Please reload this page.
[rustdoc] Calculate stability, const_stability, and deprecation on-demand - #80095
Conversation
rust-highfive
commented
Dec 16, 2020
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Previously, they would always be calculated ahead of time, which bloated the size of `clean::Item`.
7ec3996 to
1523f67Comparejyn514
commented
Dec 22, 2020
Oops, I never ran perf on this. @bors try @rust-timer queue |
rust-timer
commented
Dec 22, 2020
Awaiting bors try build completion. |
bors
commented
Dec 22, 2020
⌛ Trying commit 1523f67 with merge bf5ffc1e18462e62769c4e09320da201c8a72ac6... |
bors
commented
Dec 22, 2020
☀️ Try build successful - checks-actions |
rust-timer
commented
Dec 22, 2020
Queued bf5ffc1e18462e62769c4e09320da201c8a72ac6 with parent 353f3a3, future comparison URL. @rustbot label: +S-waiting-on-perf |
rust-timer
commented
Dec 23, 2020
Finished benchmarking try commit (bf5ffc1e18462e62769c4e09320da201c8a72ac6): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
jyn514
commented
Dec 23, 2020
Ooh, very nice! -3.5% on instruction counts, max of -2.9% on max-rss. @bors r=GuillaumeGomez rollup=never |
bors
commented
Dec 23, 2020
📌 Commit 1523f67 has been approved by |
bors
commented
Dec 23, 2020
bors
commented
Dec 23, 2020
☀️ Test successful - checks-actions |
Previously, they would always be calculated ahead of time, which bloated the size of
clean::Item.Builds on #80090 and should not be merged before. Helps with #79103 and #76382.
cc #80014 (comment)
This brings
Itemdown to 568 bytes, down from 616.