Uh oh!
There was an error while loading. Please reload this page.
Remove DefPath from Visibility and calculate it on demand - #80099
Conversation
rust-highfive
commented
Dec 17, 2020
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
b37312d to
7c75770Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7c75770 to
4b4a260Compare
This comment has been minimized.
This comment has been minimized.
4b4a260 to
a2fb4b9Comparejyn514
commented
Dec 22, 2020
@bors try @rust-timer queue |
rust-timer
commented
Dec 22, 2020
Awaiting bors try build completion. |
bors
commented
Dec 22, 2020
⌛ Trying commit a2fb4b9 with merge fbe5dedd7d90604c50736a818a6ea08e195a377e... |
bors
commented
Dec 22, 2020
☀️ Try build successful - checks-actions |
rust-timer
commented
Dec 22, 2020
Queued fbe5dedd7d90604c50736a818a6ea08e195a377e with parent 353f3a3, future comparison URL. @rustbot label: +S-waiting-on-perf |
rust-timer
commented
Dec 23, 2020
Finished benchmarking try commit (fbe5dedd7d90604c50736a818a6ea08e195a377e): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
jyn514
commented
Dec 23, 2020
-.5% on instructions, -.6% on max-rss. @bors r=GuillaumeGomez rollup=never |
bors
commented
Dec 23, 2020
📌 Commit a2fb4b9 has been approved by |
bors
commented
Dec 23, 2020
bors
commented
Dec 23, 2020
☀️ Test successful - checks-actions |
Depends on #80090 and should not be merged before. Helps with #79103 and #76382.
cc #80014 (comment) - @nnethercote I figured it out! It was simpler than I expected :)
This brings the size of
clean::Visibilitydown from 40 bytes to 8.Note that this does not remove
clean::Visibility, even though it's now basically the same asty::Visibility, because theInvsiblevariant means something different fromInheritedand I thought it would be be confusing to merge the two. See the new comments onimpl Clean for ty::Visibilityfor details.