Skip to content

Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop" - #80123

Merged
bors merged 2 commits into
rust-lang:masterfrom
beepster4096:maybe_uninit_write_slice
Dec 20, 2020
Merged

Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop"#80123
bors merged 2 commits into
rust-lang:masterfrom
beepster4096:maybe_uninit_write_slice

Conversation

@beepster4096

@beepster4096beepster4096 commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

This fixes#80116. I replaced the Rc based method I was using with a type that panics when dropped.

@rust-highfive

rust-highfive commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

r? @shepmaster

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2020
@RalfJung

RalfJung commented Dec 18, 2020

Copy link
Copy Markdown
Member

Thanks! I almost missed this PR; feel free to post a message in the issue when a PR fixes the issue so people are aware and can do the reviewing. :)

r? @RalfJung
@bors r+ rollup

@bors

bors commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 01f36c5 has been approved by RalfJung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Dec 18, 2020
@RalfJung
Rollup merge ofrust-lang#80123- DrMeepster:maybe_uninit_write_slice…
4a8f870
…, r=RalfJung
Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop"
This fixesrust-lang#80116. I replaced the `Rc` based method I was using with a type that panics when dropped.
@RalfJungRalfJung mentioned this pull request Dec 18, 2020
Closed
@RalfJung

RalfJung commented Dec 18, 2020

Copy link
Copy Markdown
Member

@bors r-

Failed on a wasm target:

error: unused import: `std::rc::Rc`
--> library/core/tests/mem.rs:3:5
|
3 | use std::rc::Rc;
| ^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 18, 2020
@beepster4096

beepster4096 commented Dec 18, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Fixed that error

@RalfJung

RalfJung commented Dec 19, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Dec 19, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 28e0d2f has been approved by RalfJung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 19, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 20, 2020
@Dylan-DPC
Rollup merge ofrust-lang#80123- DrMeepster:maybe_uninit_write_slice…
9fdd80c
…, r=RalfJung
Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop"
This fixesrust-lang#80116. I replaced the `Rc` based method I was using with a type that panics when dropped.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 20, 2020
@Dylan-DPC
Rollup merge ofrust-lang#80123- DrMeepster:maybe_uninit_write_slice…
9d5280a
…, r=RalfJung
Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop"
This fixesrust-lang#80116. I replaced the `Rc` based method I was using with a type that panics when dropped.
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Dec 20, 2020
Closed
@bors

bors commented Dec 20, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 28e0d2f with merge 59aaa2a...

@bors

bors commented Dec 20, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 59aaa2a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Dec 20, 2020
@bors
bors merged commit 59aaa2a into rust-lang:masterDec 20, 2020
@rustbotrustbot added this to the 1.50.0 milestone Dec 20, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@RalfJungRalfJung

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

Test "mem::uninit_write_slice_cloned_no_drop" leaks memory

6 participants

@beepster4096@rust-highfive@RalfJung@bors@shepmaster@rustbot