Skip to content

Revert change to trait evaluation order - #80132

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthewjasper:revert-eval-order
Dec 19, 2020
Merged

Revert change to trait evaluation order#80132
bors merged 1 commit into
rust-lang:masterfrom
matthewjasper:revert-eval-order

Conversation

@matthewjasper

@matthewjaspermatthewjasper commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

This change breaks some code and doesn't appear to enable any new code.

closes#79902

r? @nikomatsakis

@matthewjasper
Revert change to evaluation order
3e31ffd
This change breaks some code and doesn't appear to enable any new code.
@matthewjaspermatthewjasper added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 17, 2020
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2020
@matthewjaspermatthewjasper changed the title Revert change to evaluation orderRevert change to trait evaluation orderDec 18, 2020
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Dec 18, 2020
Closed
@nikomatsakis

nikomatsakis commented Dec 19, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Dec 19, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 3e31ffd has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2020
@bors

bors commented Dec 19, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3e31ffd with merge 1b6b06a...

@bors

bors commented Dec 19, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 1b6b06a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Dec 19, 2020
@bors
bors merged commit 1b6b06a into rust-lang:masterDec 19, 2020
@rustbotrustbot added this to the 1.50.0 milestone Dec 19, 2020
@matthewjasper
matthewjasper deleted the revert-eval-order branch December 20, 2020 18:39
@Mark-SimulacrumMark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 25, 2020
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Dec 27, 2020
Merged
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 27, 2020
@Mark-SimulacrumMark-Simulacrum modified the milestones: 1.50.0, 1.49.0Dec 27, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 28, 2020
@bors
Auto merge ofrust-lang#80417- Mark-Simulacrum:beta-next, r=Mark-Sim…
136dfc1
…ulacrum
[beta] backports
This backports the following to 1.49:
* Revert change to trait evaluation order rust-lang#80132
* Don't allow `const` to begin a nonterminal rust-lang#80135
* Prevent caching normalization results with a cycle rust-lang#80246
r? `@Mark-Simulacrum`
@matthiaskrgrmatthiaskrgr mentioned this pull request Jun 1, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

regression 1.49: unexpected unsized tail ICE

6 participants

@matthewjasper@nikomatsakis@bors@Mark-Simulacrum@rust-highfive@rustbot