Uh oh!
There was an error while loading. Please reload this page.
Reserve necessary space for params in generics_of - #80208
Merged
Conversation
rust-highfive
commented
Dec 19, 2020
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
matthewjasper
commented
Dec 20, 2020
Contributor
@bors r+ rollup |
bors
commented
Dec 20, 2020
Collaborator
📌 Commit 01d7f87 has been approved by |
jyn514
commented
Dec 21, 2020
Member
This could have a perf impact, are you sure it should be rolled up? |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 21, 2020
…ewjasper Reserve necessary space for params in generics_of Always reserve space for the exact number of generic parameters we need in generics_of. As far as I can see, the default is 0/4 elements based on has_self, and the vector grows on after that.
Mark-Simulacrum
commented
Dec 21, 2020
Member
@bors rollup=never |
bors
commented
Dec 22, 2020
Collaborator
bors
commented
Dec 22, 2020
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always reserve space for the exact number of generic parameters we need in generics_of. As far as I can see, the default is 0/4 elements based on has_self, and the vector grows on after that.