Skip to content

Rustdoc render public underscore_imports as Re-exports - #80267

Closed
0urobor0s wants to merge 7 commits into
rust-lang:masterfrom
0urobor0s:ouro/61592
Closed

Rustdoc render public underscore_imports as Re-exports#80267
0urobor0s wants to merge 7 commits into
rust-lang:masterfrom
0urobor0s:ouro/61592

Conversation

@0urobor0s

@0urobor0s0urobor0s commented Dec 21, 2020

Copy link
Copy Markdown

Fixes#61592

@rust-highfive

rust-highfive commented Dec 21, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ollie27 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2020
@jyn514jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 21, 2020
@jyn514jyn514 mentioned this pull request Dec 21, 2020
Closed
jyn514
jyn514 reviewed Dec 21, 2020
View reviewed changes

@jyn514jyn514 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Comment threadsrc/librustdoc/clean/mod.rs Outdated
Comment threadsrc/test/rustdoc/issue-61592.rs Outdated
@jyn514jyn514 assigned jyn514 and unassigned ollie27Dec 21, 2020
@jyn514jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2020
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Nemo157
Nemo157 reviewed Dec 22, 2020
View reviewed changes
Comment threadcompiler/rustc_error_codes/src/error_codes/E0780.md Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jyn514
jyn514 reviewed Dec 22, 2020
View reviewed changes
Comment threadcompiler/rustc_error_codes/src/error_codes/E0780.md Outdated
Comment threadcompiler/rustc_error_codes/src/error_codes/E0780.md Outdated
Comment threadcompiler/rustc_error_codes/src/error_codes/E0780.md Outdated
Comment threadsrc/librustdoc/clean/mod.rs Outdated
Comment threadsrc/librustdoc/clean/mod.rs Outdated
Comment threadsrc/librustdoc/clean/mod.rs Outdated
if pub_underscore && inlined {
rustc_errors::struct_span_err!(
cx.tcx.sess,
self.attrs.lists(sym::doc).next().unwrap().span(),

@jyn514jyn514Dec 22, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be wrong if there are multiple doc attributes. Can you add a test case for

#[doc = "xxx"]#[doc(inline)]pubuse foo::Fooas _;

@0urobor0s0urobor0sDec 23, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was working as is, maybe because of https://github.com/rust-lang/rust/blob/master/compiler/rustc_ast/src/ast.rs#L496.
Just to be safe it was changed and made some other refactoring to use the previous calculated values.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
jyn514
jyn514 reviewed Dec 23, 2020
View reviewed changes
Comment threadsrc/librustdoc/clean/mod.rs Outdated
Comment threadcompiler/rustc_error_codes/src/error_codes/E0780.md Outdated
Comment threadcompiler/rustc_error_codes/src/error_codes/E0780.md Outdated
jyn514
jyn514 reviewed Dec 23, 2020
View reviewed changes
Comment threadcompiler/rustc_error_codes/src/error_codes/E0780.md Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514

jyn514 commented Dec 30, 2020

Copy link
Copy Markdown
Member

@bors r+ squash

@bors

bors commented Dec 30, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1990713 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 31, 2020
@Dylan-DPC
Rollup merge ofrust-lang#80267- 0urobor0s:ouro/61592, r=jyn514
00d66b2
Rustdoc render public underscore_imports as Re-exports
Fixesrust-lang#61592
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Dec 31, 2020
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2020
@bors
Auto merge ofrust-lang#80267- 0urobor0s:ouro/61592, r=jyn514
a6bd524
Rustdoc render public underscore_imports as Re-exports
Fixesrust-lang#61592
@bors

bors commented Dec 31, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1990713 with merge a6bd524...

@bors

bors commented Dec 31, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing a6bd524 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Dec 31, 2020
@jyn514

jyn514 commented Dec 31, 2020

Copy link
Copy Markdown
Member

Oh right, I forgot that squash breaks github 🤦 don't worry, your changes have been merged: a6bd524

@jyn514jyn514 closed this Dec 31, 2020
@jyn514jyn514 mentioned this pull request Apr 8, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Nemo157Nemo157Nemo157 left review comments
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jyn514jyn514

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rustdoc rendering of underscore_imports a.k.a. impl-only-use is unuseful

7 participants

@0urobor0s@rust-highfive@rust-log-analyzer@jyn514@bors@Nemo157@ollie27