Uh oh!
There was an error while loading. Please reload this page.
Add more comments to trait queries - #80331
Merged
Merged
Conversation
rust-highfive
commented
Dec 23, 2020
Contributor
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
bjorn3
reviewed
Dec 23, 2020
Uh oh!
There was an error while loading. Please reload this page.
This also adds back a comment that was mistakenly removed in ac9dfc3.
varkor
commented
Dec 26, 2020
Contributor
Thanks! @bors r+ rollup |
bors
commented
Dec 26, 2020
Collaborator
📌 Commit 979d3ce has been approved by |
Closed
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 28, 2020
Add more comments to trait queries This also adds back a comment that was mistakenly removed in ac9dfc3.
This was referenced Dec 28, 2020
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 28, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#79662 (Move some more code out of CodegenBackend::{codegen_crate,link}) - rust-lang#79815 (Update RELEASES.md for 1.49.0) - rust-lang#80284 (Suggest fn ptr rather than fn item and suggest to use `Fn` trait bounds rather than the unique closure type in E0121) - rust-lang#80331 (Add more comments to trait queries) - rust-lang#80344 (use matches!() macro in more places) - rust-lang#80353 (BTreeMap: test split_off (and append) more thoroughly) - rust-lang#80362 (Document rustc_macros on nightly-rustc) - rust-lang#80399 (Remove FIXME in rustc_privacy) - rust-lang#80408 (Sync rustc_codegen_cranelift) - rust-lang#80411 (rustc_span: Remove `Symbol::with`) - rust-lang#80434 (bootstrap: put the component name in the tarball temp dir path) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds back a comment that was mistakenly removed in
ac9dfc3.