Skip to content

Introduce hir::ExprKind::Let - Take 2 - #80357

Merged
bors merged 2 commits into
rust-lang:masterfrom
c410-f3r:new-hir-let
Aug 16, 2021
Merged

Introduce hir::ExprKind::Let - Take 2#80357
bors merged 2 commits into
rust-lang:masterfrom
c410-f3r:new-hir-let

Conversation

@c410-f3r

@c410-f3rc410-f3r commented Dec 24, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Builds on #68577 and depends on #79328.

cc #53667

@rust-highfive

rust-highfive commented Dec 24, 2020

Copy link
Copy Markdown
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 24, 2020
@c410-f3rc410-f3r changed the title New hir let[WIP] Introduce hir::ExprKind::Let - Take 2Dec 24, 2020
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@davidtwco

davidtwco commented Dec 31, 2020

Copy link
Copy Markdown
Member

r? @matthewjasper for after #79328 lands :)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
matthewjasper
matthewjasper reviewed Jan 15, 2021
View reviewed changes
Comment threadcompiler/rustc_hir/src/hir.rs Outdated
Comment threadcompiler/rustc_typeck/src/check/generator_interior.rs Outdated
Comment threadcompiler/rustc_typeck/src/check/_match.rs Outdated
Comment threadcompiler/rustc_mir_build/src/build/expr/as_place.rs Outdated
Comment threadcompiler/rustc_mir_build/src/build/expr/into.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/expr.rs Outdated
Comment threadcompiler/rustc_mir_build/src/build/expr/as_rvalue.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/expr.rs Outdated
@c410-f3r

c410-f3r commented Jan 15, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hi @matthewjasper. Thanks for the review!

The current status of this PR is "pretty bare bones". Sorry for the lack of work :P
Tomorrow I will address the comments and start coding again.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
matthewjasper
matthewjasper reviewed Feb 8, 2021
View reviewed changes
Comment threadcompiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated
Comment threadcompiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated
Comment threadcompiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated
Comment threadcompiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated
Comment threadcompiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated
Comment threadcompiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated
Comment threadcompiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated
@c410-f3r
c410-f3rforce-pushed the new-hir-let branch 2 times, most recently from fd37ff9 to f3c0046CompareFebruary 11, 2021 18:53
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@c410-f3rc410-f3r changed the title [WIP] Introduce hir::ExprKind::Let - Take 2Introduce hir::ExprKind::Let - Take 2Feb 28, 2021
@c410-f3r
c410-f3r marked this pull request as ready for review February 28, 2021 22:12
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@matthewjasper

matthewjasper commented Aug 15, 2021

Copy link
Copy Markdown
Contributor

@bors r+

1 similar comment
@matthewjasper

matthewjasper commented Aug 15, 2021

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 15, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 6aa9937 has been approved by matthewjasper

@bors

bors commented Aug 16, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6aa9937 with merge 2a6fb9a...

@bors

bors commented Aug 16, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing 2a6fb9a to master...

@borsbors mentioned this pull request Aug 16, 2021
Merged
@c410-f3r

c410-f3r commented Aug 16, 2021

Copy link
Copy Markdown
ContributorAuthor

At last! Thanks @matthewjasper

This was referenced Aug 16, 2021
Merged
Merged
Merged
Closed
Merged
Merged
@rylev

rylev commented Aug 17, 2021

Copy link
Copy Markdown
Member

This change introduced some mixed performance results. The largest changes are performance wins, but regressions outweight improvements in terms of numbers. Interestingly, many of the regressions were in full builds, and I'm not quite sure why that would be.

As part of the performance triage process, I'm marking this as a performance regression. If you believe this performance regression to be justifiable or once you have an issue or PR that addresses this regression, please mark this PR with the label perf-regression-triaged.

@rustbot label +perf-regression

@camsteffencamsteffen mentioned this pull request Aug 19, 2021
Merged
@xFrednetxFrednet mentioned this pull request Aug 19, 2021
Closed
@camsteffencamsteffen mentioned this pull request Aug 20, 2021
Merged
@matthewjasper

matthewjasper commented Aug 22, 2021

Copy link
Copy Markdown
Contributor

Hmm, I can't see anything from the by query times, so maybe this is a case where codegen has been slightly regressed resulting in a slower rustc. I'll investigate some more and create a PR soon if I find anything.

@camsteffencamsteffen mentioned this pull request Aug 23, 2021
Closed
This was referenced Aug 24, 2021
Closed
Closed
@xFrednetxFrednet mentioned this pull request Aug 28, 2021
Merged
@AlexendooAlexendoo mentioned this pull request Aug 29, 2021
Closed
@c410-f3rc410-f3r mentioned this pull request Mar 14, 2022
Merged
@c410-f3rc410-f3r mentioned this pull request Apr 12, 2022
Merged
@jrudermanjruderman mentioned this pull request Nov 8, 2022
Closed
@jrudermanjruderman mentioned this pull request Nov 25, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments
@matthewjaspermatthewjaspermatthewjasper left review comments
@flip1995flip1995flip1995 approved these changes
+2 more reviewers
@jplattejplattejplatte left review comments
@camsteffencamsteffencamsteffen requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@cjgillotcjgillot

@matthewjaspermatthewjasper

Labels

A-HIRArea: The high-level intermediate representation (HIR)merged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

17 participants

@c410-f3r@rust-highfive@rust-log-analyzer@davidtwco@bors@flip1995@matthewjasper@the8472@rylev@jplatte@camsteffen@petrochenkov@cjgillot@JohnCSimon@joelpalmer@camelid@rustbot