Uh oh!
There was an error while loading. Please reload this page.
Clarify what Cell::replace returns - #80385
Merged
Merged
Conversation
rust-highfive
commented
Dec 26, 2020
Contributor
r? @cramertj (rust-highfive has picked a reviewer for you, use r? to override) |
| } | ||
| /// Replaces the contained value, and returns it. | ||
| /// Replaces the contained value with `val`, and returns the old contained value. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Replaces the contained value with `val`, and returns the old contained value. | |
| /// Replaces the wrapped value with a new one, returning the old value, | |
| /// without deinitializing either one. | |
| /// | |
| /// This function corresponds to [`std::mem::replace`](../mem/fn.replace.html). |
Why not just use the same one as RefCell::replace?
JohnCSimon
commented
Feb 1, 2021
camelid
commented
Feb 1, 2021
MemberAuthor
I was waiting for a review from @cramertj, the assignee. |
Dylan-DPC-zz
commented
Mar 9, 2021
Mark-Simulacrum
commented
Mar 11, 2021
Member
@bors r+ rollup I think this is good. I'm not convinced that reference to mem::replace or the alternative wording is better. |
bors
commented
Mar 11, 2021
Collaborator
📌 Commit c71f523 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 11, 2021
…r=Mark-Simulacrum Clarify what `Cell::replace` returns
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 11, 2021
…r=Mark-Simulacrum Clarify what `Cell::replace` returns
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 11, 2021
…r=Mark-Simulacrum Clarify what `Cell::replace` returns
This was referenced Mar 11, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#80385 (Clarify what `Cell::replace` returns) - rust-lang#82571 (Rustdoc Json: Add tests for Reexports, and improve jsondocck) - rust-lang#82860 (Add `-Z unpretty` flag for the THIR) - rust-lang#82950 (convert slice doc link to intra-doc links) - rust-lang#82965 (Add spirv extension handling in compiletest) - rust-lang#82966 (update MSYS2 link in README) - rust-lang#82979 (Fix "run" button position in error index) - rust-lang#83001 (Ignore Vim swap files) - rust-lang#83003 (rustdoc: tweak the search index format) - rust-lang#83013 (Adjust some `#[cfg]`s to take non-Unix non-Windows operating systems into account) - rust-lang#83018 (Reintroduce accidentally deleted assertions.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.