Uh oh!
There was an error while loading. Please reload this page.
Consistent no_prelude attribute - #80427
Conversation
rust-highfive
commented
Dec 28, 2020
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
oli-obk
commented
Dec 28, 2020
r? @alexcrichton since you reviewed the last PR |
bors
commented
Dec 31, 2020
☔ The latest upstream changes (presumably #80530) made this pull request unmergeable. Please resolve the merge conflicts. |
petrochenkov
commented
Dec 31, 2020
The PR is from 2016 and the RFC is from 2014, the whole idea should probably be revised before proceeding. In recent years |
bors
commented
Dec 31, 2020
☔ The latest upstream changes (presumably #80459) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
commented
Jan 4, 2021
Er sorry I don't really remember the context of a PR I reviewed 5 (!) years ago at this point. I'm probably not the best reviewer for this. Would you be ok selecting a different reviewer? r? @oli-obk |
bors
commented
Jan 7, 2021
☔ The latest upstream changes (presumably #80425) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
commented
Jan 10, 2021
☔ The latest upstream changes (presumably #80867) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
commented
Jan 11, 2021
☔ The latest upstream changes (presumably #80782) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
commented
Jan 11, 2021
I have no real knowledge of this area, but I agree that just the existance of an RFC does not motivate the change, and I'm not sure the original motivation still applies (considering that there was no activity on the tracking issue for years). cc @Kimundi@Nemo157 how do you feel about abolishing this scheme entirely and coming up with something new that does not conflict with macro imports? |
bors
commented
Jan 17, 2021
☔ The latest upstream changes (presumably #81113) made this pull request unmergeable. Please resolve the merge conflicts. |
move no-prelude tests to tests/ui remove duplicate no-implicit-prelude tests
so that #![no_prelude] is not marked as used when it is implied by #![no_implicit_prelude]
Rebases and adjusts the work of the inactive pr #32025 for rust-lang/rfcs#501
with tracking issue #20561
From the original PR:
This version does not deprecate
no_implicit_preludeas this appears to be the consent of the discussion of the original pr.