Skip to content

More uses of the matches! macro - #80467

Merged
bors merged 1 commit into
rust-lang:masterfrom
LingMan:more_matches
Dec 30, 2020
Merged

More uses of the matches! macro#80467
bors merged 1 commit into
rust-lang:masterfrom
LingMan:more_matches

Conversation

@LingMan

@LingManLingMan commented Dec 29, 2020

Copy link
Copy Markdown
Contributor

@rustbot modify labels +C-cleanup +T-compiler

@rustbotrustbot added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2020
@rust-highfive

rust-highfive commented Dec 29, 2020

Copy link
Copy Markdown
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2020
oli-obk
oli-obk requested changes Dec 29, 2020
View reviewed changes
Comment threadcompiler/rustc_ast/src/token.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/lib.rs Outdated
oli-obk
oli-obk reviewed Dec 29, 2020
View reviewed changes
Comment threadcompiler/rustc_ast/src/ast.rs Outdated
pickfire
pickfire reviewed Dec 29, 2020
View reviewed changes
Comment threadcompiler/rustc_ast/src/ast.rs Outdated
@oli-obk

oli-obk commented Dec 29, 2020

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Dec 29, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 7a41532 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2020
@JohnTitorJohnTitor mentioned this pull request Dec 30, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2020
@bors
Auto merge ofrust-lang#80503- JohnTitor:rollup-b26vglu, r=JohnTitor
d107a87
Rollup of 13 pull requests
Successful merges:
- rust-lang#79812 (Lint on redundant trailing semicolon after item)
- rust-lang#80348 (remove redundant clones (clippy::redundant_clone))
- rust-lang#80358 (Edit rustc_span documentation)
- rust-lang#80457 (Add missing commas to `rustc_ast_pretty::pp` docs)
- rust-lang#80461 (Add llvm-libunwind change to bootstrap CHANGELOG)
- rust-lang#80464 (Use Option::map_or instead of open coding it)
- rust-lang#80465 (Fix typo in ffi-pure.md)
- rust-lang#80467 (More uses of the matches! macro)
- rust-lang#80469 (Fix small typo in time comment)
- rust-lang#80472 (Use sans-serif font for the "all items" page links)
- rust-lang#80477 (Make forget intrinsic safe)
- rust-lang#80482 (don't clone copy types)
- rust-lang#80487 (don't redundantly repeat field names)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 231727d into rust-lang:masterDec 30, 2020
@rustbotrustbot added this to the 1.51.0 milestone Dec 30, 2020
@LingMan
LingMan deleted the more_matches branch December 30, 2020 17:21
@pickfirepickfire mentioned this pull request Jan 3, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk requested changes
+2 more reviewers
@pthariensflamepthariensflamepthariensflame left review comments
@pickfirepickfirepickfire left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@oli-obkoli-obk

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

7 participants

@LingMan@rust-highfive@oli-obk@bors@pthariensflame@pickfire@rustbot