Remove MIR assignments to ZST types by simonvandel · Pull Request #80493 · rust-lang/rust

simonvandel · 2020-12-29T22:38:08Z

Based on my understanding of #80475 (comment)

rust-log-analyzer · 2020-12-29T22:54:30Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

.................................................................................................... 2000/11197
...............................................................FF................................... 2100/11197
.................................................................................................... 2200/11197
.................................................................................................... 2300/11197
....................................................................F..F............................ 2400/11197
.................................................................................................... 2600/11197
.......................................iiiii........................................................ 2700/11197
.................................................................................................... 2800/11197
.................................................................................................... 2900/11197
---
.................................................................................................... 9000/11197
.................................................................................................... 9100/11197
.......................................................................................i......i..... 9200/11197
.................................................................................................... 9300/11197
..........................iiiiii..iiiiii.i.......................................................... 9400/11197
.................................................................................................... 9600/11197
.................................................................................................... 9700/11197
.................................................................................................... 9800/11197
.................................................................................................... 9900/11197
---
- error[E0080]: erroneous constant used
+ error: erroneous constant encountered
17 --> $DIR/panic-assoc-never-type.rs:16:13
18 |
19 LL | let _ = PrintName::VOID;
- | ^^^^^^^^^^^^^^^ referenced constant has errors
21 22 error: aborting due to previous error; 1 warning emitted
23 - For more information about this error, try `rustc --explain E0080`.
25 The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-assoc-never-type/panic-assoc-never-type.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args consts/const-eval/panic-assoc-never-type.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-eval/panic-assoc-never-type.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-assoc-never-type" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-assoc-never-type/auxiliary"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
warning: any use of this value will cause an error
|
|
LL | const VOID: ! = panic!();
| |
| the evaluated program panicked at 'explicit panic', /checkout/src/test/ui/consts/const-eval/panic-assoc-never-type.rs:11:21
|
note: the lint level is defined here
note: the lint level is defined here
--> /checkout/src/test/ui/consts/const-eval/panic-assoc-never-type.rs:4:9
|
LL | #![warn(const_err)]
= note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: erroneous constant encountered
--> /checkout/src/test/ui/consts/const-eval/panic-assoc-never-type.rs:16:13
--> /checkout/src/test/ui/consts/const-eval/panic-assoc-never-type.rs:16:13
|
LL | let _ = PrintName::VOID;
error: aborting due to previous error; 1 warning emitted
---
- error[E0080]: erroneous constant used
+ error: erroneous constant encountered
17 --> $DIR/panic-never-type.rs:12:13
18 |
19 LL | let _ = VOID;
- | ^^^^ referenced constant has errors
21 22 error: aborting due to previous error; 1 warning emitted
23 - For more information about this error, try `rustc --explain E0080`.
25 The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-never-type/panic-never-type.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args consts/const-eval/panic-never-type.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-eval/panic-never-type.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-never-type" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-never-type/auxiliary"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
warning: any use of this value will cause an error
|
|
LL | const VOID: ! = panic!();
| |
| the evaluated program panicked at 'explicit panic', /checkout/src/test/ui/consts/const-eval/panic-never-type.rs:8:17
|
note: the lint level is defined here
note: the lint level is defined here
--> /checkout/src/test/ui/consts/const-eval/panic-never-type.rs:4:9
|
LL | #![warn(const_err)]
= note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: erroneous constant encountered
--> /checkout/src/test/ui/consts/const-eval/panic-never-type.rs:12:13
--> /checkout/src/test/ui/consts/const-eval/panic-never-type.rs:12:13
|
LL | let _ = VOID;
error: aborting due to previous error; 1 warning emitted
------------------------------------------
---- [ui] ui/consts/recursive-zst-static.rs#default stdout ----
error in revision `default`: ui test compiled successfully!
status: exit code: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/recursive-zst-static.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "default" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/recursive-zst-static.default" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/recursive-zst-static.default/auxiliary"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
------------------------------------------
---- [ui] ui/consts/recursive-zst-static.rs#unleash stdout ----
error in revision `unleash`: ui test compiled successfully!
status: exit code: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/recursive-zst-static.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "unleash" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/recursive-zst-static.unleash" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Zunleash-the-miri-inside-of-you" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/recursive-zst-static.unleash/auxiliary"
------------------------------------------
------------------------------------------
stderr:
---
Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "ui" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-9/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "9.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:14:13

simonvandel · 2020-12-29T23:16:07Z

@oli-obk I would need some help in what to do with those test errors.

rust-log-analyzer · 2020-12-29T23:41:25Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

.................................................................................................... 1700/11197
.................................................................................................... 1800/11197
.................................................................................................... 1900/11197
.................................................................................................... 2000/11197
............................................................F.......F............................... 2100/11197
.................................................................................................... 2300/11197
.................................................................................................... 2300/11197
.......................................................................F.F.......................... 2400/11197
.................................................................................................... 2600/11197
.......................................iiiii........................................................ 2700/11197
.................................................................................................... 2800/11197
.................................................................................................... 2900/11197
---
- error[E0080]: erroneous constant used
+ error: erroneous constant encountered
17 --> $DIR/panic-never-type.rs:12:13
18 |
19 LL | let _ = VOID;
- | ^^^^ referenced constant has errors
21 22 error: aborting due to previous error; 1 warning emitted
23 - For more information about this error, try `rustc --explain E0080`.
25 The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-never-type/panic-never-type.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args consts/const-eval/panic-never-type.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-eval/panic-never-type.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-never-type" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-never-type/auxiliary"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
warning: any use of this value will cause an error
|
|
LL | const VOID: ! = panic!();
| |
| the evaluated program panicked at 'explicit panic', /checkout/src/test/ui/consts/const-eval/panic-never-type.rs:8:17
|
note: the lint level is defined here
note: the lint level is defined here
--> /checkout/src/test/ui/consts/const-eval/panic-never-type.rs:4:9
|
LL | #![warn(const_err)]
= note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: erroneous constant encountered
--> /checkout/src/test/ui/consts/const-eval/panic-never-type.rs:12:13
--> /checkout/src/test/ui/consts/const-eval/panic-never-type.rs:12:13
|
LL | let _ = VOID;
error: aborting due to previous error; 1 warning emitted
---
- error[E0080]: erroneous constant used
+ error: erroneous constant encountered
17 --> $DIR/panic-assoc-never-type.rs:16:13
18 |
19 LL | let _ = PrintName::VOID;
- | ^^^^^^^^^^^^^^^ referenced constant has errors
21 22 error: aborting due to previous error; 1 warning emitted
23 - For more information about this error, try `rustc --explain E0080`.
25 The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-assoc-never-type/panic-assoc-never-type.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args consts/const-eval/panic-assoc-never-type.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-eval/panic-assoc-never-type.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-assoc-never-type" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/panic-assoc-never-type/auxiliary"
------------------------------------------
------------------------------------------
Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
stderr:
------------------------------------------
warning: any use of this value will cause an error
|
|
LL | const VOID: ! = panic!();
| |
| the evaluated program panicked at 'explicit panic', /checkout/src/test/ui/consts/const-eval/panic-assoc-never-type.rs:11:21
|
note: the lint level is defined here
note: the lint level is defined here
--> /checkout/src/test/ui/consts/const-eval/panic-assoc-never-type.rs:4:9
|
LL | #![warn(const_err)]
= note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: erroneous constant encountered
--> /checkout/src/test/ui/consts/const-eval/panic-assoc-never-type.rs:16:13
--> /checkout/src/test/ui/consts/const-eval/panic-assoc-never-type.rs:16:13
|
LL | let _ = PrintName::VOID;
error: aborting due to previous error; 1 warning emitted
------------------------------------------
---- [ui] ui/consts/recursive-zst-static.rs#unleash stdout ----
error in revision `unleash`: ui test compiled successfully!
status: exit code: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/recursive-zst-static.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "unleash" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/recursive-zst-static.unleash" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Zunleash-the-miri-inside-of-you" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/recursive-zst-static.unleash/auxiliary"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
------------------------------------------
---- [ui] ui/consts/recursive-zst-static.rs#default stdout ----
error in revision `default`: ui test compiled successfully!
status: exit code: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/recursive-zst-static.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "default" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/recursive-zst-static.default" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/recursive-zst-static.default/auxiliary"
------------------------------------------
------------------------------------------
stderr:
---
test result: FAILED. 11109 passed; 4 failed; 84 ignored; 0 measured; 0 filtered out; finished in 155.47s
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "ui" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-9/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "9.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:17:03

oli-obk · 2020-12-30T00:49:31Z

Based on my understanding

Jup, exactly what I had in mind. I just thought we already had some code for this and just forgot turning it on again, but apparently not?

You can bless most tests that changed. We do need to fix recursive-zst-static.rs... I think we can't optimize away deref and index projections, even if they produce ZSTs (at least within static items). That's a bit overspecific for my liking, but this is a very curious situation with static ZSTs that needs to be solved somehow. Maybe just don't apply the optimization within static items?

rust-log-analyzer · 2020-12-30T09:31:00Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

.................................................................................................... 9000/11226
.................................................................................................... 9100/11226
.................................................................................................... 9200/11226
.............i........i............................................................................. 9300/11226
....................................................iiiiii..iiiiii.i................................ 9400/11226
.................................................................................................... 9600/11226
.................................................................................................... 9700/11226
.................................................................................................... 9800/11226
..............test [ui] ui/issues/issue-74564-if-expr-stack-overflow.rs has been running for over 60 seconds
---
Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 238 tests
iii............iii...ii..i.ii.........i.ii..........i..............i.............i.i...iii.......iii 100/238
..........i.....i.......F.....i.i.i....ii..iiii......................................ii....i.i...i.. 200/238
Some tests failed in compiletest suite=codegen mode=codegen host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
failures:
---- [codegen] codegen/naked-functions.rs stdout ----
---- [codegen] codegen/naked-functions.rs stdout ----
error: verification with 'FileCheck' failed
status: exit code: 1
command: "/usr/lib/llvm-9/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/naked-functions/naked-functions.ll" "/checkout/src/test/codegen/naked-functions.rs"
------------------------------------------
------------------------------------------
stderr:
stderr:
------------------------------------------
/checkout/src/test/codegen/naked-functions.rs:12:17: error: CHECK-NEXT: is not on the line after the previous match
// CHECK-NEXT: ret void
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/naked-functions/naked-functions.ll:10:2: note: 'next' match was here
ret void
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/naked-functions/naked-functions.ll:8:7: note: previous match ended here
^
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/naked-functions/naked-functions.ll:9:1: note: non-matching line after previous match is here
%0 = alloca {}, align 1
------------------------------------------
---
test result: FAILED. 192 passed; 1 failed; 45 ignored; 0 measured; 0 filtered out; finished in 3.45s
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/codegen" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "codegen" "--mode" "codegen" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-9/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "9.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:19:02

oli-obk · 2020-12-30T09:39:15Z

You can fix codegen tests by looking at build/x86_64-unknown-linux-gnu/test/codegen/naked-functions/naked-functions.ll and checking how CHECK comments can be adjusted to make the test pass again.

simonvandel · 2020-12-30T09:52:18Z

When the MIR does not have _0 = const ();, the LLVM-IR contains a %0 = alloca {}, align 1 line.
I can of course change the expected LLVM-IR, but i'm unsure why the additional LLVM-IR line is generated in the first place. Is it too simplistic to think that LLVM would never have to see ZSTs?

oli-obk · 2020-12-30T10:51:15Z

@bors r+

weird... but I guess that is an independent codegen problem

bors · 2020-12-30T10:51:16Z

📌 Commit 22f94499cc9c397420c4cf8ba0bbcabf4018bae7 has been approved by oli-obk

wesleywiser · 2020-12-30T15:35:29Z

@bors r-

I thought we had already did this via a combination of the ConstProp and SimplifyLocals passes. Some simple tests on the playground seem to confirm this. Looking through the tests, it seems (with 1 or 2 exceptions), the only assignments of ZSTs removed are assignments to the return place (_0). Is it legal for us to skip writing to the return place in this case (or in general)?

wesleywiser · 2020-12-30T15:46:36Z

Ah, ok. I see there was discussion in #80475 about this. I'm willing to accept the logic that we never need writes of ZST values even in the return place but in that case, I think the better thing to do would be to change the logic in SimplifyLocals so that it only considers _0 used if it's not a ZST. I believe that would be simpler and perhaps more efficient than repeating the logic in InstCombine.

simonvandel · 2020-12-30T16:12:32Z

I'll see how I can modify SimplifyLocals 👍

simonvandel · 2020-12-30T21:29:15Z

Force pushed a new approach that is an extension of SimplifyLocals instead.
Do we want a perf run just in case this has any effect?

wesleywiser · 2020-12-30T21:49:33Z

We refactored this loop a few months ago to push most of this kind of logic into UsedLocals. i think that's probably the place we need to make this change.
It might just be a matter of adjusting this logic:
rust/compiler/rustc_mir/src/transform/simplify.rs
Lines 392 to 398 in e226704
/// Checks if local is used.
///
/// Return place and arguments are always considered used.
fnis_used(&self,local:Local) -> bool{
trace!("is_used({:?}): use_count: {:?}", local,self.use_count[local]);
local.as_u32() <= self.arg_count || self.use_count[local] != 0
}

Took a stab at moving the logic into UsedLocals with the lastest commits

nagisa · 2020-12-31T01:28:56Z

I feel like this is probably invalid – for #[naked] functions to be well-formed, they usually should only contain an optional inline assembly call and ret. alloca here will likely make any use of #[naked] plain unsound.
If #[naked] wasn't as unstable as they are, this would be blocking, and IMHO it needing change now warrants at least a folllow-up issue.

FWIW I'm pretty sure we skip codegenning ZST assignments/allocas/etc in the llvm backend which is why with _0 = const () in MIR it never generated any LLVM. Now that there are no assignments to the _0, its probably taking a different path in the backend and ends up generating the alloca anyway.
If I had to guess this local is failing to be marked as a SSA value?

So this pr should be blocked until the codegen is fixed to not generate ZST allocas for _0 if it is not assigned in MIR?
I haven't looked at codegen before, so any pointers are appreciated.

Yeah, that looks like a use of an uninitialized ZST local marking it as non-SSA (implicit use in return terminator?). That part would be in non_ssa_locals.

The latest commit tries to eliminate the alloca

bors · 2021-01-14T17:53:14Z

☔ The latest upstream changes (presumably #79328) made this pull request unmergeable. Please resolve the merge conflicts.

nagisa · 2021-01-14T18:00:04Z

I wonder if anything breaks if we do in fact just go ahead and unconditionally mark any variable without assignments as "ssa".

I tried replacing is_zst with true which at least didn't break test/{mir-opt,codegen}. Should i push that instead of the current zst handling?

Lets not do that in the current PR, especially because apparently this was added as part of a ICE fix, but without tests. I will experiment with it separately.

cjgillot · 2021-01-21T19:24:21Z

Some assignments are not removed compared to earlier versions of this PR. Why are those not optimized now?

rust-log-analyzer · 2021-02-02T19:53:40Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 29 tests
iiiiiiiiiiiiiiiiiiiiiiiiiiiii
finished in 0.063 seconds
Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
finished in 9.954 seconds
Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 116 tests
iiiiiiiiii.i.i..i..i..ii....i.i....ii...........iiii........i.....i...i.......ii.i.ii.....iiii...... 100/116
test result: ok. 78 passed; 0 failed; 38 ignored; 0 measured; 0 filtered out; finished in 2.32s
finished in 2.381 seconds
Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
---
Suite("src/test/run-make") not skipped for "bootstrap::test::RunMake" -- not in ["src/tools/tidy"]
Check compiletest suite=run-make mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
running 20 tests
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
iiiiiiiiiiii.F......
---- [run-make] run-make/const_fn_mir stdout ----
error: make failed
error: make failed
status: exit code: 2
command: "make"
stdout:
------------------------------------------
LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/const_fn_mir/const_fn_mir:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/const_fn_mir/const_fn_mir -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/const_fn_mir/const_fn_mir main.rs --emit=mir -o "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/const_fn_mir/const_fn_mir"/dump.mir
diff -u --strip-trailing-cr dump.mir "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/const_fn_mir/const_fn_mir"/dump.mir
--- dump.mir 2021-02-02 19:18:33.691805373 +0000
+++ /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/const_fn_mir/const_fn_mir/dump.mir 2021-02-02 19:53:27.965363974 +0000
@@ -14,7 +14,6 @@
bb1: {
bb1: {
StorageDead(_1); // scope 0 at main.rs:9:10: 9:11
- _0 = const (); // scope 0 at main.rs:8:11: 10:2
return; // scope 0 at main.rs:10:2: 10:2
}
Makefile:4: recipe for target 'all' failed
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
warning: ignoring --out-dir flag due to -o flag
warning: 1 warning emitted
make: *** [all] Error 1
------------------------------------------
failures:
[run-make] run-make/const_fn_mir
test result: FAILED. 7 passed; 1 failed; 12 ignored; 0 measured; 0 filtered out; finished in 0.50s
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-make" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "run-make" "--mode" "run-make" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-9/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python3" "--lldb-python" "/usr/bin/python3" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "9.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--llvm-bin-dir" "/usr/lib/llvm-9/bin" "--cc" "cc" "--cxx" "c++" "--cflags" "-ffunction-sections -fdata-sections -fPIC -m64" "--ar" "ar" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:32:48

oli-obk · 2021-02-15T12:36:37Z

@bors r+ rollup-

bors · 2021-02-15T12:36:38Z

📌 Commit bab2e56 has been approved by oli-obk

bjorn3 · 2021-02-15T12:38:43Z

I think you wanted to do

@bors rollup=never

rollup- only clears the rollup state.

oli-obk · 2021-02-15T12:39:43Z

ooops, thanks. I had a feeling something was wrong when I typed that, but couldn't figure out what

bors · 2021-02-15T21:32:32Z

⌛ Testing commit bab2e56 with merge ef6fe77536ea1d8c722aad9fc949e031f01123c9...

rust-log-analyzer · 2021-02-15T21:51:46Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)


---- [mir-opt] mir-opt/inline/inline-instruction-set.rs stdout ----
27 - }
28 - 29 - bb2: {
- + _2 = const (); // scope 1 at $DIR/inline-instruction-set.rs:43:5: 43:26
31 StorageDead(_2); // scope 0 at $DIR/inline-instruction-set.rs:43:26: 43:27
32 StorageLive(_3); // scope 0 at $DIR/inline-instruction-set.rs:46:5: 46:30
33 - _3 = instruction_set_default() -> bb3; // scope 0 at $DIR/inline-instruction-set.rs:46:5: 46:30
thread '[mir-opt] mir-opt/inline/inline-instruction-set.rs' panicked at 'Actual MIR output differs from expected MIR output /checkout/src/test/mir-opt/inline/inline_instruction_set.t32.Inline.diff', src/tools/compiletest/src/runtest.rs:3457:25
failures:
[mir-opt] mir-opt/inline/inline-instruction-set.rs
[mir-opt] mir-opt/inline/inline-instruction-set.rs
test result: FAILED. 150 passed; 1 failed; 3 ignored; 0 measured; 0 filtered out; finished in 3.62s
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/mir-opt" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "mir-opt" "--mode" "mir-opt" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-9/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python3" "--lldb-python" "/usr/bin/python3" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:16:05

bors · 2021-02-15T21:53:49Z

💔 Test failed - checks-actions

bors · 2021-02-21T08:30:11Z

☔ The latest upstream changes (presumably #79100) made this pull request unmergeable. Please resolve the merge conflicts.

JohnCSimon · 2021-03-07T22:25:11Z

ping from triage:
@simonvandel - Can you please resolve the test failures and merge conflicts?

rust-highfive assigned oli-obk Dec 29, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2020

oli-obk reviewed Dec 29, 2020
View reviewed changes

Comment threadcompiler/rustc_mir/src/transform/instcombine.rs Outdated

oli-obk reviewed Dec 30, 2020
View reviewed changes

Comment threadcompiler/rustc_mir/src/transform/instcombine.rs Outdated

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 30, 2020

simonvandel force-pushed the remove-zst-assign branch from 22f9449 to d1a87e0Compare December 30, 2020 21:25

wesleywiser reviewed Dec 30, 2020
View reviewed changes

nagisa reviewed Dec 31, 2020
View reviewed changes

nagisa reviewed Jan 14, 2021
View reviewed changes

cjgillot reviewed Jan 21, 2021
View reviewed changes

simonvandel added 2 commits January 30, 2021 21:09

Extend SimplifyLocals to remove ZST writes
ee62461

Move ZST check inside UsedLocals
ac1cebb

simonvandel force-pushed the remove-zst-assign branch from f1ae27c to 60b0bb3Compare February 2, 2021 19:18

Do not emit alloca for ZST local even if it is uninitialized
bab2e56

simonvandel force-pushed the remove-zst-assign branch from 60b0bb3 to bab2e56Compare February 2, 2021 20:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 15, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2021

oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2021

erikdesjardins mentioned this pull request Mar 14, 2021
Rebase and fixup #80493: Remove MIR assignments to ZST types #83118
Merged

bors closed this in 7a7bbdbMar 15, 2021

	/// Checks if local is used.
	///
	/// Return place and arguments are always considered used.
	fnis_used(&self,local:Local) -> bool{
	trace!("is_used({:?}): use_count: {:?}", local,self.use_count[local]);
	local.as_u32() <= self.arg_count \|\| self.use_count[local] != 0
	}

Uh oh!

Uh oh!

Conversation

simonvandel commented Dec 29, 2020

Uh oh!

Uh oh!

rust-log-analyzer commented Dec 29, 2020

Uh oh!

simonvandel commented Dec 29, 2020

Uh oh!

rust-log-analyzer commented Dec 29, 2020

Uh oh!

oli-obk commented Dec 30, 2020

Uh oh!

Uh oh!

rust-log-analyzer commented Dec 30, 2020

Uh oh!

oli-obk commented Dec 30, 2020

Uh oh!

simonvandel commented Dec 30, 2020

Uh oh!

oli-obk commented Dec 30, 2020

Uh oh!

bors commented Dec 30, 2020

Uh oh!

wesleywiser commented Dec 30, 2020

Uh oh!

wesleywiser commented Dec 30, 2020

Uh oh!

simonvandel commented Dec 30, 2020

Uh oh!

simonvandel commented Dec 30, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bors commented Jan 14, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-log-analyzer commented Feb 2, 2021

Uh oh!

oli-obk commented Feb 15, 2021

Uh oh!

bors commented Feb 15, 2021

Uh oh!

bjorn3 commented Feb 15, 2021

Uh oh!

oli-obk commented Feb 15, 2021

Uh oh!

bors commented Feb 15, 2021

Uh oh!

rust-log-analyzer commented Feb 15, 2021

Uh oh!

bors commented Feb 15, 2021

Uh oh!

bors commented Feb 21, 2021

Uh oh!

JohnCSimon commented Mar 7, 2021

Uh oh!

Reviewers

Assignees

Labels