Skip to content

support pattern as const parents in type_of - #80551

Merged
bors merged 1 commit into
rust-lang:masterfrom
lcnr:const-arg-wildcard
Jan 1, 2021
Merged

support pattern as const parents in type_of#80551
bors merged 1 commit into
rust-lang:masterfrom
lcnr:const-arg-wildcard

Conversation

@lcnr

@lcnrlcnr commented Dec 31, 2020

Copy link
Copy Markdown
Contributor

nice to know that there's still stuff about rust i didn't know about 😆

fixes#80531

r? @varkor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2020
@lcnrlcnr added the A-const-generics Area: const generics (parameters and arguments) label Dec 31, 2020
Comment threadcompiler/rustc_typeck/src/collect/type_of.rs Outdated
@varkor

Copy link
Copy Markdown
Contributor

Maybe the delay in min_const_generics stabilisation was a good thing after all...

@lcnr
lcnrforce-pushed the const-arg-wildcard branch from 250461c to 2aef46bCompareDecember 31, 2020 13:11
@varkor

Copy link
Copy Markdown
Contributor

Great, thanks!

@bors r+ rollup

@bors

bors commented Dec 31, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2aef46b has been approved by varkor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2020
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 31, 2020
support pattern as const parents in type_of
nice to know that there's still stuff about rust i didn't know about 😆
fixesrust-lang#80531
r? ``@varkor``
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 1, 2021
Rollup of 8 pull requests
Successful merges:
- rust-lang#80323 (Update and improve `rustc_codegen_{llvm,ssa}` docs)
- rust-lang#80368 (rustdoc: Render visibilities succinctly)
- rust-lang#80514 (Fix broken ./x.py install)
- rust-lang#80519 (Take type defaults into account in suggestions to reorder generic parameters)
- rust-lang#80526 (Update LLVM)
- rust-lang#80532 (remove unnecessary trailing semicolon from bootstrap)
- rust-lang#80548 (FIx ICE on wf check for foreign fns)
- rust-lang#80551 (support pattern as const parents in type_of)
Failed merges:
- rust-lang#80547 (In which we start to parse const generics defaults)
r? `@ghost`
`@rustbot` modify labels: rollup
@camelidcamelid added the A-patterns Relating to patterns and pattern matching label Jan 1, 2021
@bors
bors merged commit 96c11f9 into rust-lang:masterJan 1, 2021
@rustbotrustbot added this to the 1.51.0 milestone Jan 1, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-const-genericsArea: const generics (parameters and arguments)A-patternsRelating to patterns and pattern matchingS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE with const-generic enum pattern

6 participants

@lcnr@varkor@bors@rust-highfive@camelid@rustbot