Skip to content

Clean bootstrap artifacts on x.py clean - #80574

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:clean-bootstrap
Jan 2, 2021
Merged

Clean bootstrap artifacts on x.py clean#80574
bors merged 1 commit into
rust-lang:masterfrom
jyn514:clean-bootstrap

Conversation

@jyn514

@jyn514jyn514 commented Jan 1, 2021

Copy link
Copy Markdown
Member

@jyn514jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jan 1, 2021
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2021
@Mark-Simulacrum

Mark-Simulacrum commented Jan 1, 2021

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jan 1, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 139ef75 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2021
@m-ou-sem-ou-se mentioned this pull request Jan 2, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2021
@bors
Auto merge ofrust-lang#80615- m-ou-se:rollup-xz67at2, r=m-ou-se
90ccf4f
Rollup of 6 pull requests
Successful merges:
- rust-lang#80546 (clippy fixes for librustdoc)
- rust-lang#80555 (Improve library tracking issue template)
- rust-lang#80574 (Clean bootstrap artifacts on `x.py clean`)
- rust-lang#80578 (improve unconditional_panic description)
- rust-lang#80599 (`const_generics_defaults`: don't ICE in the unimplemented parts)
- rust-lang#80613 (Diag: print enum variant instead of enum type)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@RalfJung

RalfJung commented Jan 2, 2021

Copy link
Copy Markdown
Member

Will this mean that there's no way to just clean the library/compiler artifacts? ./x.py clean && ./x.py check will now take a lot longer if it has to entirely re-build bootstrap first...

@Mark-Simulacrum

Mark-Simulacrum commented Jan 2, 2021

Copy link
Copy Markdown
Member

Hm, I'd expect bootstrap to compile in around a minute, but I guess maybe it's grown over time. Probably we want some kind of flags or something...

@RalfJung

RalfJung commented Jan 2, 2021

Copy link
Copy Markdown
Member

A minute is a lot, since x.py check is rather fast.

@jyn514

jyn514 commented Jan 2, 2021

Copy link
Copy Markdown
MemberAuthor

Will this mean that there's no way to just clean the library/compiler artifacts?

@RalfJung you could run rm -r build/$TARGET/stage1* (or any other folders you want to clean), would that work? I would rather not make clean too complicated.

@Mark-Simulacrum

Mark-Simulacrum commented Jan 2, 2021

Copy link
Copy Markdown
Member

That said I guess a reasonable question might be - why do we want to clean bootstrap? It should be very reliably recompiled (unlike other artifacts some times)

@RalfJung

RalfJung commented Jan 2, 2021

Copy link
Copy Markdown
Member

@jyn514 yeah that's what I used to do; `x.py clean is much shorter though. ;)

@Mark-Simulacrum one good reason to clean bootstrap is to remove outdated artifacts. When the beta compiler gets bumped, the old files remain, so the bootstrap folder keeps growing and I sometims remove it manually. I do that much less often than x.py clean, though.

@Mark-Simulacrum

Mark-Simulacrum commented Jan 2, 2021

Copy link
Copy Markdown
Member

It seems like we could delete the bootstrap build directory when the bootstrap compiler changes without too much trouble. If that's the only reason to want to touch it, I think it's better.

@bors
bors merged commit 4890c06 into rust-lang:masterJan 2, 2021
@rustbotrustbot added this to the 1.51.0 milestone Jan 2, 2021
@jyn514
jyn514 deleted the clean-bootstrap branch January 2, 2021 15:42
@rylevrylev mentioned this pull request Feb 16, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 21, 2021
@JohnTitor
Rollup merge ofrust-lang#82177- rylev:no-delete-bootstrap-windows, …
1a6c48a
…r=Mark-Simulacrum
Do not delete bootstrap.exe on Windows during clean
Windows does not allow deleting currently running executables.
This an addition to `@jyn514's` change in rust-lang#80574.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 21, 2021
@JohnTitor
Rollup merge ofrust-lang#82177- rylev:no-delete-bootstrap-windows, …
df078f0
…r=Mark-Simulacrum
Do not delete bootstrap.exe on Windows during clean
Windows does not allow deleting currently running executables.
This an addition to ``@jyn514's`` change in rust-lang#80574.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 21, 2021
@JohnTitor
Rollup merge ofrust-lang#82177- rylev:no-delete-bootstrap-windows, …
13a3c6e
…r=Mark-Simulacrum
Do not delete bootstrap.exe on Windows during clean
Windows does not allow deleting currently running executables.
This an addition to ```@jyn514's``` change in rust-lang#80574.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

x.py clean does not clean bootstrap anymore

6 participants

@jyn514@Mark-Simulacrum@bors@RalfJung@rust-highfive@rustbot