Skip to content

Give a better error for download-ci-llvm if .xz is not supported - #80581

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:ci-llvm
Jan 2, 2021
Merged

Give a better error for download-ci-llvm if .xz is not supported#80581
bors merged 1 commit into
rust-lang:masterfrom
jyn514:ci-llvm

Conversation

@jyn514

@jyn514jyn514 commented Jan 1, 2021

Copy link
Copy Markdown
Member

Previously:

curl: (22) The requested URL returned error: 404
failed to run: curl -# -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmp6ptXJV https://ci-artifacts.rust-lang.org/rustc-builds/99ad5a1a2824fea1ecf60068fd3636beae7ea2da/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz

Now:

error: XZ support is required to download LLVM
help: consider disabling `download-ci-llvm` or using a different version of python
Build completed unsuccessfully in 0:00:00

Follow-up to #80435.

r? @Mark-Simulacrum

@jyn514jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust labels Jan 1, 2021
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2021
@jyn514

jyn514 commented Jan 1, 2021

Copy link
Copy Markdown
MemberAuthor

It's possible to special case this so that it will work before 1.51, but since download-ci-llvm was only introduced a couple versions ago I don't think there's a need. The fix is easy enough - using python3 x.py instead works fine.

@rust-log-analyzer

rust-log-analyzer commented Jan 1, 2021

Copy link
Copy Markdown
Collaborator

The job mingw-check failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
configure: rust.channel := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions := True
configure: dist.missing-tools := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: configure: run `python /checkout/x.py --help`
configure: ---
Checking which error codes lack tests...
Found 435 error codes
Found 0 error codes with no tests
Done!
tidy error: /checkout/src/bootstrap/bootstrap.py:493: line longer than 100 chars
some tidy checks failed
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build"
expected success, got: exit code: 1

@Mark-Simulacrum

Mark-Simulacrum commented Jan 1, 2021

Copy link
Copy Markdown
Member

Can we tell people a specific version? Maybe python 3 at least?

@jyn514
Give a better error for download-ci-llvm if .xz is not supported
b5019d6
Previously:
```
curl: (22) The requested URL returned error: 404
failed to run: curl -# -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmp6ptXJV https://ci-artifacts.rust-lang.org/rustc-builds/99ad5a1a2824fea1ecf60068fd3636beae7ea2da/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
```
Now:
```
error: XZ support is required to download LLVM
help: consider disabling `download-ci-llvm` or using a different version of python
Build completed unsuccessfully in 0:00:00
```
@jyn514

jyn514 commented Jan 1, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Sure, I changed this to recommend python3.

@Mark-Simulacrum

Mark-Simulacrum commented Jan 1, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 1, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit b5019d6 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2021
@Mark-Simulacrum

Mark-Simulacrum commented Jan 1, 2021

Copy link
Copy Markdown
Member

@bors p=1

@bors

bors commented Jan 1, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b5019d6 with merge 417fe47...

@bors

bors commented Jan 2, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 417fe47 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2021
@bors
bors merged commit 417fe47 into rust-lang:masterJan 2, 2021
@rustbotrustbot added this to the 1.51.0 milestone Jan 2, 2021
@jyn514
jyn514 deleted the ci-llvm branch January 2, 2021 01:38
@jyn514jyn514 mentioned this pull request Jan 2, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to Rustmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jyn514@rust-log-analyzer@Mark-Simulacrum@bors@rust-highfive@rustbot