Uh oh!
There was an error while loading. Please reload this page.
Various ABI refactorings - #80594
Merged
Merged
Conversation
MemberAuthor
The rust abi changes may have a perf impact. @bors try @rust-timer queue |
rust-timer
commented
Jan 1, 2021
Collaborator
Awaiting bors try build completion. |
bors
commented
Jan 1, 2021
Collaborator
⌛ Trying commit aa907768403aacd3b5750b496ad5823891176e3d with merge 075e7afe5cd922c1d7be743e49df45cb2d3646ad... |
rust-timer
commented
Jan 1, 2021
Collaborator
Awaiting bors try build completion. |
bors
commented
Jan 1, 2021
Collaborator
☀️ Try build successful - checks-actions |
rust-timer
commented
Jan 1, 2021
Collaborator
Queued 075e7afe5cd922c1d7be743e49df45cb2d3646ad with parent 206ee1e, future comparison URL. @rustbot label: +S-waiting-on-perf |
bjorn3
commented
Jan 1, 2021
MemberAuthor
Overall this is a slight (<0.5%) improvement. |
rust-timer
commented
Jan 1, 2021
Collaborator
Finished benchmarking try commit (075e7afe5cd922c1d7be743e49df45cb2d3646ad): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
…n return position Abi::ScalarPair is only ever used for types that don't have a stable layout anyway so this doesn't break any FFI. It does however reduce the amount of special casing on the abi outside of the code responsible for abi specific adjustments to the pass mode.
bjorn3
marked this pull request as ready for review
January 23, 2021 12:56
bjorn3
commented
Jan 23, 2021
MemberAuthor
I think this is enough to port cg_clif to the same abi handling infrastructure as cg_llvm. Randomly assigning |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
petrochenkov
commented
Jan 23, 2021
Contributor
I'm not familiar with this code and not sure what are the full implications of da0309c, but this looks reasonable. |
bjorn3
commented
Jan 23, 2021
MemberAuthor
I am not sure about da0309c either, but it is probably the reason this PR improves performance and it removes a special case so I would like to see it landing, but I would like for someone who is more familiar with the abi handling to take a look. |
petrochenkov
commented
Jan 23, 2021
Contributor
@bors r+ |
bors
commented
Jan 23, 2021
Collaborator
📌 Commit fa12fdb has been approved by |
bors
commented
Jan 24, 2021
Collaborator
bors
commented
Jan 24, 2021
Collaborator
☀️ Test successful - checks-actions |
alexcrichton
commented
Jan 25, 2021
Member
I believe this has caused a breaking change in wasm32-unknown-unknown's ABI -- #81386 |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 19, 2023
Ensure sanity of all computed ABIs This moves the ABI sanity assertions from the codegen backend to the ABI computation logic. Sadly, due to past mistakes, we [have to](rust-lang#117351 (comment)) be able to compute a sane ABI for nonsensical function types like `extern "C" fn(str) -> str`. So to make the sanity check pass we first need to make all ABI adjustment deal with unsized types... and we have no shared infrastructure for those adjustments, so that's a bunch of copy-paste. At least we have assertions failing loudly when one accidentally sets a different mode for an unsized argument. To achieve this, this re-lands the parts of rust-lang#80594 that got reverted in rust-lang#81388. To avoid breaking wasm ABI again, that ABI now explicitly opts-in to the (wrong, broken) ABI that we currently keep for backwards compatibility. That's still better than having *every* ABI use the wrong broken default! Cc `@bjorn3` Fixesrust-lang#115845
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 19, 2023
Ensure sanity of all computed ABIs This moves the ABI sanity assertions from the codegen backend to the ABI computation logic. Sadly, due to past mistakes, we [have to](rust-lang#117351 (comment)) be able to compute a sane ABI for nonsensical function types like `extern "C" fn(str) -> str`. So to make the sanity check pass we first need to make all ABI adjustment deal with unsized types... and we have no shared infrastructure for those adjustments, so that's a bunch of copy-paste. At least we have assertions failing loudly when one accidentally sets a different mode for an unsized argument. To achieve this, this re-lands the parts of rust-lang#80594 that got reverted in rust-lang#81388. To avoid breaking wasm ABI again, that ABI now explicitly opts-in to the (wrong, broken) ABI that we currently keep for backwards compatibility. That's still better than having *every* ABI use the wrong broken default! Cc `@bjorn3` Fixesrust-lang#115845
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 19, 2023
Ensure sanity of all computed ABIs This moves the ABI sanity assertions from the codegen backend to the ABI computation logic. Sadly, due to past mistakes, we [have to](rust-lang#117351 (comment)) be able to compute a sane ABI for nonsensical function types like `extern "C" fn(str) -> str`. So to make the sanity check pass we first need to make all ABI adjustment deal with unsized types... and we have no shared infrastructure for those adjustments, so that's a bunch of copy-paste. At least we have assertions failing loudly when one accidentally sets a different mode for an unsized argument. To achieve this, this re-lands the parts of rust-lang#80594 that got reverted in rust-lang#81388. To avoid breaking wasm ABI again, that ABI now explicitly opts-in to the (wrong, broken) ABI that we currently keep for backwards compatibility. That's still better than having *every* ABI use the wrong broken default! Cc `@bjorn3` Fixesrust-lang#115845
bors added a commit
to rust-lang/miri
that referenced
this pull request
Nov 21, 2023
Ensure sanity of all computed ABIs This moves the ABI sanity assertions from the codegen backend to the ABI computation logic. Sadly, due to past mistakes, we [have to](rust-lang/rust#117351 (comment)) be able to compute a sane ABI for nonsensical function types like `extern "C" fn(str) -> str`. So to make the sanity check pass we first need to make all ABI adjustment deal with unsized types... and we have no shared infrastructure for those adjustments, so that's a bunch of copy-paste. At least we have assertions failing loudly when one accidentally sets a different mode for an unsized argument. To achieve this, this re-lands the parts of rust-lang/rust#80594 that got reverted in rust-lang/rust#81388. To avoid breaking wasm ABI again, that ABI now explicitly opts-in to the (wrong, broken) ABI that we currently keep for backwards compatibility. That's still better than having *every* ABI use the wrong broken default! Cc `@bjorn3` Fixesrust-lang/rust#115845
lnicola pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
Ensure sanity of all computed ABIs This moves the ABI sanity assertions from the codegen backend to the ABI computation logic. Sadly, due to past mistakes, we [have to](rust-lang/rust#117351 (comment)) be able to compute a sane ABI for nonsensical function types like `extern "C" fn(str) -> str`. So to make the sanity check pass we first need to make all ABI adjustment deal with unsized types... and we have no shared infrastructure for those adjustments, so that's a bunch of copy-paste. At least we have assertions failing loudly when one accidentally sets a different mode for an unsized argument. To achieve this, this re-lands the parts of rust-lang/rust#80594 that got reverted in rust-lang/rust#81388. To avoid breaking wasm ABI again, that ABI now explicitly opts-in to the (wrong, broken) ABI that we currently keep for backwards compatibility. That's still better than having *every* ABI use the wrong broken default! Cc `@bjorn3` Fixesrust-lang/rust#115845
RalfJung pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
Ensure sanity of all computed ABIs This moves the ABI sanity assertions from the codegen backend to the ABI computation logic. Sadly, due to past mistakes, we [have to](rust-lang/rust#117351 (comment)) be able to compute a sane ABI for nonsensical function types like `extern "C" fn(str) -> str`. So to make the sanity check pass we first need to make all ABI adjustment deal with unsized types... and we have no shared infrastructure for those adjustments, so that's a bunch of copy-paste. At least we have assertions failing loudly when one accidentally sets a different mode for an unsized argument. To achieve this, this re-lands the parts of rust-lang/rust#80594 that got reverted in rust-lang/rust#81388. To avoid breaking wasm ABI again, that ABI now explicitly opts-in to the (wrong, broken) ABI that we currently keep for backwards compatibility. That's still better than having *every* ABI use the wrong broken default! Cc `@bjorn3` Fixesrust-lang/rust#115845
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes changes to the rust abi and various refactorings that will hopefully make it easier to use the abi handling infrastructure of rustc in cg_clif. There are several refactorings that I haven't done. I am opening this draft PR to check that I haven't broken any non x86_64 architectures.
r? @ghost