check that first arg to `panic!()` in const is `&str` by abonander · Pull Request #80734 · rust-lang/rust

abonander · 2021-01-05T21:55:34Z

closes#66693

~~TODO: regression test~~

cc @RalfJung for error message wording

rust-highfive · 2021-01-05T21:55:37Z

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

oli-obk

does this affect any tests? If not, please add a test in a test that has the const_panic feature activated.

abonander · 2021-01-05T22:15:18Z

does this affect any tests? If not, please add a test in a test that has the const_panic feature activated.

Yep, I was getting to that. I just wanted to post as draft for early feedback on the error message.

oli-obk · 2021-01-05T22:16:46Z

Yep, I was getting to that. I just wanted to post as draft for early feedback on the error message.

oh duh, I should have read your main PR message properly..

abonander · 2021-01-08T00:40:28Z

@RalfJung @oli-obk I adjusted the wording, fixed the check and added UI tests. I noticed a discrepancy between panics in array length expressions and normal consts so I put them in separate files. Should the tests cover const fn as well?

abonander · 2021-01-08T03:23:59Z

I went ahead and made sure to cover const fn as well.

RalfJung · 2021-01-08T10:20:51Z

@RalfJung @oli-obk I adjusted the wording, fixed the check and added UI tests. I noticed a discrepancy between panics in array length expressions and normal consts so I put them in separate files. Should the tests cover const fn as well?

You can have more than one //~ ERROR in a single file, and that is usually preferred to group testcases.

abonander · 2021-01-08T19:05:08Z

@RalfJung well the problem I had with arrays is that it seems their length expressions get const-evaluated in an earlier pass than const or static or const fn because the compiler would issue an error for let _ = [0i32; panic!(1)] and then exit before even visiting the other declarations. I assumed this was to be expected since arrays need to know their lengths for typechecking to finish, thus I separated the test cases into two files. Otherwise, I did combine test cases where I could.

RalfJung · 2021-01-08T19:56:22Z

That's a good point, thanks. Maybe add a comment in the array-length-test-file explaining why this is a separate file.

SergioBenitez · 2021-02-26T23:51:34Z

It seems like this is waiting on rather minor changes, is that right? @RalfJung I'm happy to push this forward if so.

RalfJung · 2021-02-27T12:37:36Z

@SergioBenitez I left some comments that are all minor, yes (see the open discussions). I don't know if @oli-obk has further comments; he is more familiar with the const-checking code.

abonander · 2021-02-28T18:59:21Z

@RalfJung sorry, been busy with work. I think that's your nits addressed now.

~~@JohnCSimon if you want to update the triage label.~~ (nevermind, I got it)

abonander · 2021-02-28T19:00:17Z

@rustbot label: +S-waiting-on-review -S-waiting-on-author

oli-obk

Just a nit, then this lgtm

oli-obk · 2021-03-01T16:39:42Z

@bors r+

bors · 2021-03-01T16:39:44Z

📌 Commit 5a33f53 has been approved by oli-obk

…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#80734 (check that first arg to `panic!()` in const is `&str`) - rust-lang#81932 (Always compile rustdoc with debug logging enabled when `download-rustc` is set) - rust-lang#82018 (Remove the dummy cache in `DocContext`; delete RenderInfo) - rust-lang#82598 (Check stability and feature attributes in rustdoc) - rust-lang#82655 (Highlight identifier span instead of whole pattern span in `unused` lint) - rust-lang#82662 (Warn about unknown doc attributes) - rust-lang#82676 (Change twice used large const table to static) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned oli-obk Jan 5, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 5, 2021

abonander force-pushed the ab/issue-66693 branch from 3c21bf7 to 6412cbaCompare January 5, 2021 21:57

This comment has been minimized.
Sign in to view

oli-obk reviewed Jan 5, 2021
View reviewed changes

Comment threadcompiler/rustc_mir/src/transform/check_consts/validation.rs Outdated
Comment threadcompiler/rustc_mir/src/transform/check_consts/validation.rs Outdated

abonander force-pushed the ab/issue-66693 branch 3 times, most recently from f437c33 to c6c1997Compare January 5, 2021 22:25

This comment has been minimized.
Sign in to view

RalfJung reviewed Jan 6, 2021
View reviewed changes

Comment threadcompiler/rustc_mir/src/transform/check_consts/ops.rs Outdated

abonander force-pushed the ab/issue-66693 branch 3 times, most recently from 9511e21 to a5e15c7Compare January 8, 2021 00:37

abonander commented Jan 8, 2021
View reviewed changes

Comment threadcompiler/rustc_mir/src/transform/check_consts/validation.rs Outdated

abonander marked this pull request as ready for review January 8, 2021 00:40

This comment has been minimized.
Sign in to view

abonander force-pushed the ab/issue-66693 branch 2 times, most recently from 9bcdbad to aa12833Compare January 8, 2021 03:23

abonander requested review from RalfJung and oli-obk January 8, 2021 03:25

abonander commented Jan 8, 2021
View reviewed changes

Comment threadsrc/test/ui/consts/issue-66693-panic-in-array-len.rs Outdated

RalfJung reviewed Jan 9, 2021
View reviewed changes

Comment threadsrc/test/ui/consts/issue-66693-panic-in-array-len.rs Outdated

abonander force-pushed the ab/issue-66693 branch from aa12833 to 1920ef5Compare February 28, 2021 18:58

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2021

abonander force-pushed the ab/issue-66693 branch 2 times, most recently from 9b4f2a0 to 8765a3dCompare February 28, 2021 19:12

oli-obk reviewed Mar 1, 2021
View reviewed changes

Comment threadcompiler/rustc_mir/src/transform/check_consts/validation.rs Outdated

check that first arg to panic!() in const is &str
5a33f53

abonander force-pushed the ab/issue-66693 branch from 8765a3d to 5a33f53Compare March 1, 2021 16:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2021

GuillaumeGomez mentioned this pull request Mar 1, 2021
Rollup of 7 pull requests #82688
Merged

bors merged commit 865cf0c into rust-lang:masterMar 2, 2021

rustbot added this to the 1.52.0 milestone Mar 2, 2021

abonander deleted the ab/issue-66693 branch March 2, 2021 17:16

Alexendoo mentioned this pull request Mar 3, 2021
ICE with const _: () = panic!(String::new());#76013
Closed

camelid added the A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) label Mar 14, 2021

RalfJung mentioned this pull request Jun 1, 2021
Stabilize RFC 2345: Allow panicking in constants #85194
Closed

tmandry mentioned this pull request Mar 4, 2022
Tracking issue for RFC 2345, "Allow panicking in constants" (const_panic) #51999
Closed
5 tasks

Uh oh!

Uh oh!

Conversation

abonander commented Jan 5, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jan 5, 2021

Uh oh!

This comment has been minimized.

oli-obk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abonander commented Jan 5, 2021

Uh oh!

oli-obk commented Jan 5, 2021

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

abonander commented Jan 8, 2021

Uh oh!

This comment has been minimized.

abonander commented Jan 8, 2021

Uh oh!

RalfJung commented Jan 8, 2021

Uh oh!

abonander commented Jan 8, 2021

Uh oh!

RalfJung commented Jan 8, 2021

Uh oh!

Uh oh!

Uh oh!

SergioBenitez commented Feb 26, 2021

Uh oh!

RalfJung commented Feb 27, 2021

Uh oh!

abonander commented Feb 28, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abonander commented Feb 28, 2021

Uh oh!

oli-obk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oli-obk commented Mar 1, 2021

Uh oh!

bors commented Mar 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

abonander commented Jan 5, 2021•
edited
Loading

abonander commented Feb 28, 2021•
edited
Loading