Skip to content

Move some tests to more reasonable directories - 1 - #80880

Merged
bors merged 1 commit into
rust-lang:masterfrom
c410-f3r:tests-tests-tests
Jan 12, 2021
Merged

Move some tests to more reasonable directories - 1#80880
bors merged 1 commit into
rust-lang:masterfrom
c410-f3r:tests-tests-tests

Conversation

@c410-f3r

@c410-f3rc410-f3r commented Jan 10, 2021

Copy link
Copy Markdown
Contributor

The idea is to move issues/ui tests in small batches

r? @petrochenkov

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JohnTitor
JohnTitor approved these changes Jan 10, 2021
View reviewed changes

@JohnTitorJohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@petrochenkov

petrochenkov commented Jan 10, 2021

Copy link
Copy Markdown
Contributor

cc #73494

@petrochenkov

petrochenkov commented Jan 11, 2021

Copy link
Copy Markdown
Contributor

@c410-f3r
Have you tried to use the classifier tool, or its pre-collected results from #73494 (comment)?
I think it generally makes sense to start with tests with the highest confidence scores (>1, then >0), then we'll be able to re-train the classifier to get slightly better results for the remaining tests.

@petrochenkov

petrochenkov commented Jan 11, 2021

Copy link
Copy Markdown
Contributor

Regarding specific changes:

  • looks like issue-10031.rs isn't testing anything useful now and can be removed (or it can be moved to structs perhaps) (also the cross-crate subdirectory is pointless, we should move its contents to other directories)
  • moving issue-10200.rs to parser is a mistake, I'd put it to resolve (even it's not the original purpose of the test)
  • otherwise LGTM

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2021
@c410-f3r

c410-f3r commented Jan 11, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@c410-f3r
Have you tried to use the classifier tool, or its pre-collected results from #73494 (comment)?
I think it generally makes sense to start with tests with the highest confidence scores (>1, then >0), then we'll be able to re-train the classifier to get slightly better results for the remaining tests.

I started the pre-collected list in a sequential order but yeah, starting with high confidence scores is indeed a better approach. Thanks!

Regarding specific changes:
...

All suggested changes were made and more tests will be added in a following PR

@petrochenkov

petrochenkov commented Jan 11, 2021

Copy link
Copy Markdown
Contributor

Thanks!
r=me after squashing commits.

@petrochenkov

petrochenkov commented Jan 11, 2021

Copy link
Copy Markdown
Contributor

@c410-f3r
I've regenerated the test list, now it's sorted by confidence scores.

@bors r+

@bors

bors commented Jan 11, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 2055e4c has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 11, 2021
@JohnTitorJohnTitor mentioned this pull request Jan 12, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2021
@bors
Auto merge ofrust-lang#80939- JohnTitor:rollup-pymns4q, r=JohnTitor
b6b4616
Rollup of 8 pull requests
Successful merges:
- rust-lang#79757 (Replace tabs earlier in diagnostics)
- rust-lang#80600 (Add `MaybeUninit` method `array_assume_init`)
- rust-lang#80880 (Move some tests to more reasonable directories)
- rust-lang#80897 (driver: Use `atty` instead of rolling our own)
- rust-lang#80898 (Add another test case for rust-lang#79808)
- rust-lang#80917 (core/slice: remove doc comment about scoped borrow)
- rust-lang#80927 (Replace a simple `if let` with the `matches` macro)
- rust-lang#80930 (fix typo in trait method mutability mismatch help)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7c79e5b into rust-lang:masterJan 12, 2021
@rustbotrustbot added this to the 1.51.0 milestone Jan 12, 2021
@c410-f3rc410-f3r changed the title Move some tests to more reasonable directoriesMove some tests to more reasonable directories - 0Jan 12, 2021
@c410-f3rc410-f3r changed the title Move some tests to more reasonable directories - 0Move some tests to more reasonable directories - 1Jan 12, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

7 participants

@c410-f3r@rust-log-analyzer@petrochenkov@bors@JohnTitor@rust-highfive@rustbot