Skip to content

Feature-gate pointer and reference in intra-doc links - #81015

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:feature-gate-ptr
Jan 18, 2021
Merged

Feature-gate pointer and reference in intra-doc links#81015
bors merged 1 commit into
rust-lang:masterfrom
jyn514:feature-gate-ptr

Conversation

@jyn514

@jyn514jyn514 commented Jan 14, 2021•
edited
Loading

Copy link
Copy Markdown
Member

r? @camelid

Addresses (but does not close) #80896.

@jyn514jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name labels Jan 14, 2021
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2021
@jyn514

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
camelid
camelid reviewed Jan 14, 2021
View reviewed changes
Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
camelid
camelid reviewed Jan 14, 2021
View reviewed changes
Comment threadsrc/test/rustdoc-ui/intra-doc/feature-gate-pointer.rs Outdated
Comment threadsrc/test/rustdoc-ui/intra-doc/feature-gate-pointer.stderr Outdated
@camelid

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
camelid
camelid reviewed Jan 15, 2021
View reviewed changes
Comment threadsrc/doc/unstable-book/src/language-features/intra-doc-pointers.md Outdated
camelid
camelid reviewed Jan 15, 2021
View reviewed changes
Comment threadsrc/doc/unstable-book/src/language-features/intra-doc-pointers.md Outdated
@camelid

camelid commented Jan 15, 2021

Copy link
Copy Markdown
Member

FYI, you accidentally committed some submodules :)

@jyn514

jyn514 commented Jan 15, 2021

Copy link
Copy Markdown
MemberAuthor

Thanks, fixed.

@bors

This comment has been minimized.

Sign in to view
@jyn514
Feature-gate pointer and reference in intra-doc links
fc53594
- Only feature gate associated items
- Add docs to unstable book
@jyn514

jyn514 commented Jan 17, 2021

Copy link
Copy Markdown
MemberAuthor

@camelid did you have other concerns for me to address?

@camelid

camelid commented Jan 17, 2021

Copy link
Copy Markdown
Member

I see that you had to adjust tidy so it checks test/rustdoc-ui for feature gates. I don't know tidy but it seems harmless, so r=me.

@jyn514

jyn514 commented Jan 17, 2021

Copy link
Copy Markdown
MemberAuthor

Thanks!

@bors r=camelid

@bors

bors commented Jan 17, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit fc53594 has been approved by camelid

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2021
@bors

bors commented Jan 18, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit fc53594 with merge 66eb982...

@bors

bors commented Jan 18, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: camelid
Pushing 66eb982 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 18, 2021
@bors
bors merged commit 66eb982 into rust-lang:masterJan 18, 2021
@rustbotrustbot added this to the 1.51.0 milestone Jan 18, 2021
This was referenced Jan 18, 2021
Closed
Merged
@jyn514
jyn514 deleted the feature-gate-ptr branch January 18, 2021 15:04
@jyn514jyn514 mentioned this pull request Jan 18, 2021
Merged
3 tasks
@jyn514jyn514 mentioned this pull request Feb 22, 2021
Merged
@fmeasefmease mentioned this pull request Oct 10, 2025
Open
2 tasks
@coderabbitaicoderabbitaiBot mentioned this pull request Aug 8, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camelidcamelidcamelid left review comments

Assignees

@camelidcamelid

Labels

A-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by namemerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jyn514@rust-highfive@rust-log-analyzer@camelid@bors@rustbot