Skip to content

Stabilize core::slice::fill_with - #81048

Merged
bors merged 1 commit into
rust-lang:masterfrom
yoshuawuyts:stabilize-core-slice-fill-with
Jan 31, 2021
Merged

Stabilize core::slice::fill_with#81048
bors merged 1 commit into
rust-lang:masterfrom
yoshuawuyts:stabilize-core-slice-fill-with

Conversation

@yoshuawuyts

@yoshuawuytsyoshuawuyts commented Jan 15, 2021

Copy link
Copy Markdown
Member

Tracking issue: #79221

This stabilizes the slice_fill_with feature for Rust 1.51, following the stabilization of slice_fill in 1.50. This was requested by libs team members in #79213.

This PR also adds the "memset" alias for slice::fill_with, mirroring the alias set on the slice::fill sibling API. This will ensure someone looking for "memset" will find both variants.

r? @Amanieu

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2021
@yoshuawuytsyoshuawuyts mentioned this pull request Jan 15, 2021
2 tasks
@jonas-schievinkjonas-schievink added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api [DEPRECATED; DO NOT USE] labels Jan 15, 2021
@Amanieu

Copy link
Copy Markdown
Member

@rfcbot fcp merge

@rfcbot

rfcbot commented Jan 15, 2021

Copy link
Copy Markdown

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbotrfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 15, 2021
@rfcbot

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbotrfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jan 20, 2021
@rfcbotrfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Jan 30, 2021
@rfcbot

Copy link
Copy Markdown

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbotrfcbot added to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 30, 2021
@m-ou-se

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jan 30, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit b50df6d has been approved by m-ou-se

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2021
…as-schievink
Rollup of 18 pull requests
Successful merges:
- rust-lang#78044 (Implement io::Seek for io::Empty)
- rust-lang#79285 (Stabilize Arc::{increment,decrement}_strong_count)
- rust-lang#80053 (stabilise `cargo test -- --include-ignored`)
- rust-lang#80279 (Implement missing `AsMut<str>` for `str`)
- rust-lang#80470 (Stabilize by-value `[T; N]` iterator `core::array::IntoIter`)
- rust-lang#80945 (Add Box::downcast() for dyn Any + Send + Sync)
- rust-lang#81048 (Stabilize `core::slice::fill_with`)
- rust-lang#81198 (Remove requirement that forces symmetric and transitive PartialEq impls to exist)
- rust-lang#81422 (Account for existing `_` field pattern when suggesting `..`)
- rust-lang#81472 (Clone entire `TokenCursor` when collecting tokens)
- rust-lang#81484 (Optimize decimal formatting of 128-bit integers)
- rust-lang#81491 (Balance sidebar `Deref` cycle check with main content)
- rust-lang#81509 (Add a regression test for ICE of bad_placeholder_type)
- rust-lang#81547 (Edit rustc_typeck top-level docs)
- rust-lang#81550 (Replace predecessor with range in collections documentation)
- rust-lang#81558 (Fix ascii art text wrapping in mobile)
- rust-lang#81562 (Clarify that InPlaceIterable guarantees extend to all advancing iterator methods.)
- rust-lang#81563 (Improve docblock readability on small screen)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0793fab into rust-lang:masterJan 31, 2021
@rustbotrustbot added this to the 1.51.0 milestone Jan 31, 2021
@yoshuawuyts
yoshuawuyts deleted the stabilize-core-slice-fill-with branch January 31, 2021 12:11
@apirainoapiraino removed the to-announce Announce this issue on triage meeting label Feb 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.needs-fcpThis change is insta-stable, or significant enough to need a team FCP to proceed.relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@yoshuawuyts@Amanieu@rfcbot@m-ou-se@bors@jonas-schievink@apiraino@rust-highfive@rustbot