Skip to content

Query-ify needs_gdb_debug_scripts_section - #81056

Closed
Aaron1011 wants to merge 1 commit into
rust-lang:masterfrom
Aaron1011:query-gdb-debug
Closed

Query-ify needs_gdb_debug_scripts_section#81056
Aaron1011 wants to merge 1 commit into
rust-lang:masterfrom
Aaron1011:query-gdb-debug

Conversation

@Aaron1011

@Aaron1011Aaron1011 commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

This ensures that a codegen unit DepNode does not have a direct
dependency on the crate's attributes

@rust-highfive

rust-highfive commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

r? @ecstatic-morse

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2021
@Aaron1011

Aaron1011 commented Jan 15, 2021

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Jan 15, 2021

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@bors

bors commented Jan 15, 2021

Copy link
Copy Markdown
Collaborator

⌛ Trying commit ecde548133cec4a4a8ca0b1c9ff382abc44cfcd5 with merge a3c8e320ca13e4cc1253c85b7cfbaf98a455560f...

@bors

bors commented Jan 15, 2021

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: a3c8e320ca13e4cc1253c85b7cfbaf98a455560f (a3c8e320ca13e4cc1253c85b7cfbaf98a455560f)

@rust-timer

rust-timer commented Jan 15, 2021

Copy link
Copy Markdown
Collaborator

Queued a3c8e320ca13e4cc1253c85b7cfbaf98a455560f with parent bc39d4d, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 15, 2021
@jyn514jyn514 added A-codegen Area: Code generation A-incr-comp Area: Incremental compilation I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 15, 2021
jyn514
jyn514 reviewed Jan 15, 2021
View reviewed changes
Comment threadcompiler/rustc_middle/src/query/mod.rs Outdated
@rust-timer

rust-timer commented Jan 16, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit (a3c8e320ca13e4cc1253c85b7cfbaf98a455560f): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 16, 2021
bjorn3
bjorn3 reviewed Jan 17, 2021
View reviewed changes
Comment threadcompiler/rustc_codegen_llvm/src/attributes.rs Outdated
@Aaron1011

Aaron1011 commented Jan 31, 2021

Copy link
Copy Markdown
ContributorAuthor

r? @estebank

@bors

bors commented Feb 2, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #81660) made this pull request unmergeable. Please resolve the merge conflicts.

@bjorn3bjorn3 mentioned this pull request Feb 2, 2021
Merged
@Aaron1011
Query-ify needs_gdb_debug_scripts_section
3667b1d
This ensures that a codegen unit DepNode does not have a direct
dependency on the crate's attributes
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Feb 5, 2021
@m-ou-se
Rollup merge ofrust-lang#81664- bjorn3:no_codegen_hir, r=lcnr
add80c9
Avoid a hir access inside get_static
Together with rust-lang#81056 this ensures that the codegen unit DepNode doesn't have a direct dependency on any part of the hir.
@jonas-schievinkjonas-schievink added the relnotes-perf Performance improvements that should be mentioned in the release notes. label Feb 9, 2021
@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2021
@Aaron1011

Aaron1011 commented Mar 2, 2021

Copy link
Copy Markdown
ContributorAuthor

@estebank Are there any changes that you'd like me to make?

@Aaron1011

Aaron1011 commented Mar 16, 2021

Copy link
Copy Markdown
ContributorAuthor

PR #79519 may have reduced the need for this:

@bors try @rust-timer queue

@rust-timer

rust-timer commented Mar 16, 2021

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 16, 2021
@bors

bors commented Mar 16, 2021

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 3667b1d with merge c071c3594f1d95ba283af8252d803e1b74690fe0...

@bors

bors commented Mar 16, 2021

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: c071c3594f1d95ba283af8252d803e1b74690fe0 (c071c3594f1d95ba283af8252d803e1b74690fe0)

@rust-timer

rust-timer commented Mar 16, 2021

Copy link
Copy Markdown
Collaborator

Queued c071c3594f1d95ba283af8252d803e1b74690fe0 with parent f24ce9b, future comparison URL.

@rust-timer

rust-timer commented Mar 16, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit (c071c3594f1d95ba283af8252d803e1b74690fe0): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 16, 2021
@estebank

estebank commented Mar 17, 2021

Copy link
Copy Markdown
Contributor

The performance improvements seem to have gone away.

r=me, if you still want to land it

@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2021
@Dylan-DPC-zz

Dylan-DPC-zz commented Apr 6, 2021

Copy link
Copy Markdown

@Aaron1011 any updates?

@Aaron1011

Aaron1011 commented Apr 16, 2021

Copy link
Copy Markdown
ContributorAuthor

Without any net performance improvement, landing this would probably just be unnecessary churn.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3bjorn3bjorn3 left review comments
+1 more reviewer
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@estebankestebank

Labels

A-codegenArea: Code generationA-incr-compArea: Incremental compilationI-compiletimeIssue: Problems and improvements with respect to compile times.relnotes-perfPerformance improvements that should be mentioned in the release notes.S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@Aaron1011@rust-highfive@rust-timer@bors@estebank@Dylan-DPC-zz@bjorn3@jyn514@jonas-schievink@JohnCSimon@ecstatic-morse@rustbot