Skip to content

FALSE is not 1u8 but 0u8, of cource. - #8137

Closed
omasanori wants to merge 1 commit into
rust-lang:masterfrom
omasanori:ubool-false
Closed

FALSE is not 1u8 but 0u8, of cource.#8137
omasanori wants to merge 1 commit into
rust-lang:masterfrom
omasanori:ubool-false

Conversation

@omasanori

Copy link
Copy Markdown
Contributor

Obvious mistake, but there is no failure because no code uses FALSE.

Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
@bblum

Copy link
Copy Markdown
Contributor

my goodness :P

@thestinger

Copy link
Copy Markdown
Contributor

Why do we have these TRUE and FALSE constants at all? It could just be treating those as bool in the API if they're really a u8 with the value 0 or 1.

bors added a commit that referenced this pull request Jul 30, 2013
Obvious mistake, but there is no failure because no code uses FALSE.
@borsbors closed this Jul 31, 2013
@bstrie

Copy link
Copy Markdown
Contributor

@thestinger looks like it's for comparing against the output of C functions?

flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 30, 2021
Fix commits and formatting of CHANGELOG.md
r? `@Manishearth`
Follow up to rust-lang#8136
I think the beta commit update didn't take the backport we've done into account. I fixed the commit ranges. And while I was at it, I also applied my usual formatting to the changelog entries.
changelog: none
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
8137: Fix box pattern inference panic r=flodiebold a=Veykril
Fixesrust-lang#6560
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@omasanori@bblum@thestinger@bstrie@bors