Skip to content

rustdoc: Name fields of ResolutionFailure::WrongNamespace - #81575

Merged
bors merged 1 commit into
rust-lang:masterfrom
camelid:rustdoc-wrongnamespace-cleanup
Feb 25, 2021
Merged

rustdoc: Name fields of ResolutionFailure::WrongNamespace#81575
bors merged 1 commit into
rust-lang:masterfrom
camelid:rustdoc-wrongnamespace-cleanup

Conversation

@camelid

@camelidcamelid commented Jan 30, 2021

Copy link
Copy Markdown
Member

It makes it clearer that the Namespace is the one requested by the
disambiguator, rather than the actual namespace of the item. It said
that in the docs before, but now you can tell in the code so it reduces
the potential for confusion.

@camelidcamelid added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 30, 2021
@rust-highfive

rust-highfive commented Jan 30, 2021

Copy link
Copy Markdown
Contributor

Some changes occurred in intra-doc-links.

cc @jyn514

@rust-highfive

rust-highfive commented Jan 30, 2021

Copy link
Copy Markdown
Contributor

r? @ollie27

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2021
@camelid
camelidforce-pushed the rustdoc-wrongnamespace-cleanup branch from 1b5e317 to 0f7ad89CompareJanuary 30, 2021 23:55
camelid
camelid commented Jan 30, 2021
View reviewed changes
Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camelid
camelidforce-pushed the rustdoc-wrongnamespace-cleanup branch from 0f7ad89 to 222af0dCompareJanuary 31, 2021 01:01
jyn514
jyn514 reviewed Feb 3, 2021
View reviewed changes
Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
@camelid

camelid commented Feb 16, 2021

Copy link
Copy Markdown
MemberAuthor

r? @jyn514

@rust-highfiverust-highfive assigned jyn514 and unassigned ollie27Feb 16, 2021
jyn514
jyn514 reviewed Feb 23, 2021
View reviewed changes

@jyn514jyn514 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with https://github.com/rust-lang/rust/pull/81575/files#r569816145 addressed.

Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
@jyn514jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021
@camelid
rustdoc: Name fields of ResolutionFailure::WrongNamespace
a03950b
It makes it clearer that the `Namespace` is the one requested by the
disambiguator, rather than the actual namespace of the item. It said
that in the docs before, but now you can tell in the code so it reduces
the potential for confusion.
@camelid
camelidforce-pushed the rustdoc-wrongnamespace-cleanup branch from 222af0d to a03950bCompareFebruary 24, 2021 04:59
@camelidcamelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2021
@jyn514

jyn514 commented Feb 24, 2021

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Feb 24, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit a03950b has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 24, 2021
@JohnTitor
Rollup merge ofrust-lang#81575- camelid:rustdoc-wrongnamespace-clea…
6fe9144
…nup, r=jyn514
rustdoc: Name fields of `ResolutionFailure::WrongNamespace`
It makes it clearer that the `Namespace` is the one requested by the
disambiguator, rather than the actual namespace of the item. It said
that in the docs before, but now you can tell in the code so it reduces
the potential for confusion.
@JohnTitorJohnTitor mentioned this pull request Feb 24, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 24, 2021
@Dylan-DPC
Rollup merge ofrust-lang#81575- camelid:rustdoc-wrongnamespace-clea…
09456c2
…nup, r=jyn514
rustdoc: Name fields of `ResolutionFailure::WrongNamespace`
It makes it clearer that the `Namespace` is the one requested by the
disambiguator, rather than the actual namespace of the item. It said
that in the docs before, but now you can tell in the code so it reduces
the potential for confusion.
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Feb 24, 2021
Closed
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Feb 25, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2021
@bors
Auto merge ofrust-lang#82517- Dylan-DPC:rollup-a1958gb, r=Dylan-DPC
0ab7c1d
Rollup of 16 pull requests
Successful merges:
- rust-lang#75807 (Convert core/num/mod.rs to intra-doc links)
- rust-lang#80534 (Use #[doc = include_str!()] in std)
- rust-lang#80553 (Add an impl of Error on `Arc<impl Error>`.)
- rust-lang#81167 (Make ptr::write const)
- rust-lang#81575 (rustdoc: Name fields of `ResolutionFailure::WrongNamespace`)
- rust-lang#81713 (Account for associated consts in the "unstable assoc item name colission" lint)
- rust-lang#82078 (Make char and u8 methods const)
- rust-lang#82087 (Fix ICE caused by suggestion with no code substitutions)
- rust-lang#82090 (Do not consider using a semicolon inside of a different-crate macro)
- rust-lang#82213 (Slices for vecs)
- rust-lang#82214 (Remove redundant to_string calls)
- rust-lang#82220 (fix the false 'defined here' messages)
- rust-lang#82313 (Update normalize.css to 8.0.1)
- rust-lang#82321 (AST: Remove some unnecessary boxes)
- rust-lang#82364 (Improve error msgs when found type is deref of expected)
- rust-lang#82514 (Update Clippy)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 749d70a into rust-lang:masterFeb 25, 2021
@rustbotrustbot added this to the 1.52.0 milestone Feb 25, 2021
@camelid
camelid deleted the rustdoc-wrongnamespace-cleanup branch February 25, 2021 21:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jyn514jyn514

Labels

A-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by nameC-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.52.0

Development

Successfully merging this pull request may close these issues.

7 participants

@camelid@rust-highfive@rust-log-analyzer@jyn514@bors@ollie27@rustbot