Uh oh!
There was an error while loading. Please reload this page.
[beta] backports - #82062
Merged
Merged
Conversation
The panic happens when in recovery parsing a full `impl` (`parse_item_impl`) fails and we drop the `DiagnosticBuilder` for the recovery suggestion and return the `parse_item_impl` error. We now raise the original error "expected identifier found `impl`" when parsing the `impl` fails. Note that the regression test is slightly simplified version of the original repro in rust-lang#81806, to make the error output smaller and more resilient to unrelated changes in parser error messages. Fixesrust-lang#81806
This reverts commit 31375d2.
rust-highfive
commented
Feb 13, 2021
Contributor
|
Mark-Simulacrum
commented
Feb 13, 2021
MemberAuthor
@bors r+ rollup=never |
bors
commented
Feb 13, 2021
Collaborator
📌 Commit b016024 has been approved by |
bors
commented
Feb 14, 2021
Collaborator
bors
commented
Feb 14, 2021
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports some PRs and bumps to the released stable compiler:
mutin arguments for functions documentation Don't displaymutin arguments for functions documentation #81831r? @Mark-Simulacrum