Skip to content

rustdoc: Remove duplicate "List of all items" - #82484

Merged
bors merged 2 commits into
rust-lang:masterfrom
bugadani:docfix
Feb 26, 2021
Merged

rustdoc: Remove duplicate "List of all items"#82484
bors merged 2 commits into
rust-lang:masterfrom
bugadani:docfix

Conversation

@bugadani

@bugadanibugadani commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

Closes#82477

r? @jyn514

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2021
@jyn514

jyn514 commented Feb 24, 2021

Copy link
Copy Markdown
Member

Can you add a test case for this so it doesn't regress again?

@jyn514jyn514 added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 24, 2021
@bugadani

bugadani commented Feb 24, 2021

Copy link
Copy Markdown
ContributorAuthor

Ugh... I don't know about that, this is a rather random piece of string that would be checked. Should we test the whole template?

@jyn514

jyn514 commented Feb 24, 2021

Copy link
Copy Markdown
Member

Hmm, I guess since this is literal text there's not a ton of point in testing it ... @GuillaumeGomez what do you think?

r=me on the fix though

r? @GuillaumeGomez

@jyn514jyn514 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2021
@GuillaumeGomez

GuillaumeGomez commented Feb 24, 2021

Copy link
Copy Markdown
Member

You can check that you don't have that string, but yes, please add a test. :)

@jyn514

jyn514 commented Feb 24, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 24, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit d3f75eb has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2021
@camelid

camelid commented Feb 25, 2021•
edited by GuillaumeGomez
Loading

Copy link
Copy Markdown
Member

This seems completely fine to backport, so 👍 from me.

@GuillaumeGomez

GuillaumeGomez commented Feb 25, 2021

Copy link
Copy Markdown
Member

@bors: rollup

@apirainoapiraino added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 25, 2021
@Aaron1011Aaron1011 mentioned this pull request Feb 25, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2021
@bors
Auto merge ofrust-lang#82530- Aaron1011:rollup-aalwq15, r=Aaron1011
c0a54cc
Rollup of 11 pull requests
Successful merges:
- rust-lang#82269 (Cleanup `PpMode` and friends)
- rust-lang#82431 (Set RUST_BACKTRACE=0 when running `treat-err-as-bug` tests)
- rust-lang#82441 (Fix typo in sanitizer flag in unstable book.)
- rust-lang#82463 (panic_bounds_checks should be panic_bounds_check)
- rust-lang#82464 (Update outdated comment in unix Command.)
- rust-lang#82467 (library: Normalize safety-for-unsafe-block comments)
- rust-lang#82468 (Move pick_by_value_method docs above function header)
- rust-lang#82484 (rustdoc: Remove duplicate "List of all items")
- rust-lang#82502 (Only look for HTML `tidy` when running rustdoc tests)
- rust-lang#82503 (fix typo in `pre-commit.sh`)
- rust-lang#82510 (Fix typo in `param_env_reveal_all_normalized`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 8250a25 into rust-lang:masterFeb 26, 2021
@rustbotrustbot added this to the 1.52.0 milestone Feb 26, 2021
@cuvipercuviper mentioned this pull request Mar 11, 2021
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 11, 2021
@cuvipercuviper modified the milestones: 1.52.0, 1.51.0Mar 11, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2021
@bors
Auto merge ofrust-lang#82996- cuviper:beta-next, r=Mark-Simulacrum
50b9553
[beta] backports
This backports some beta-accepted PRs and one additional LLVM fix for s390x.
- rustdoc: treat edition 2021 as unstable rust-lang#82207
- Fix popping singleton paths in when generating E0433 rust-lang#82259
- libtest: Fix unwrap panic on duplicate TestDesc rust-lang#82274
- [intra-doc links] Don't check feature gates of items re-exported across crates rust-lang#82295
- rustdoc: Remove duplicate "List of all items" rust-lang#82484
- Substitute erased lifetimes on bad placeholder type rust-lang#82494
- Revert LLVM D81803 because it broke Windows 7 rust-lang#82605
- [SystemZ] Assign the full space for promoted and split outgoing args. rust-lang/llvm-project#95
r? `@Mark-Simulacrum`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

rustdoc: "List of all items" title shown twice

9 participants

@bugadani@jyn514@GuillaumeGomez@bors@camelid@cuviper@apiraino@rust-highfive@rustbot