Skip to content

Reuse std::sys::unsupported::pipe on hermit - #82500

Merged
bors merged 1 commit into
rust-lang:masterfrom
CDirkx:hermit-pipe
Mar 19, 2021
Merged

Reuse std::sys::unsupported::pipe on hermit#82500
bors merged 1 commit into
rust-lang:masterfrom
CDirkx:hermit-pipe

Conversation

@CDirkx

@CDirkxCDirkx commented Feb 24, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Pipes are not supported on hermit and hermit/pipe.rs is identical to unsupported/pipe.rs. This PR reduces duplication between the two by doing the following on hermit:

#[path = "../unsupported/pipe.rs"]pubmod pipe;

@rust-highfive

rust-highfive commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2021
@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2021
JohnTitor
JohnTitor approved these changes Mar 18, 2021
View reviewed changes

@JohnTitorJohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me 👍

@joshtriplett

joshtriplett commented Mar 18, 2021

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Mar 18, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 2cbea9f has been approved by joshtriplett

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 18, 2021
@Dylan-DPC
Rollup merge ofrust-lang#82500- CDirkx:hermit-pipe, r=joshtriplett
0531012
Reuse `std::sys::unsupported::pipe` on `hermit`
Pipes are not supported on `hermit` and `hermit/pipe.rs` is identical to `unsupported/pipe.rs`. This PR reduces duplication between the two by doing the following on `hermit`:
```rust
#[path = "../unsupported/pipe.rs"]
pub mod pipe;
```
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Mar 18, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 18, 2021
@Dylan-DPC
Rollup merge ofrust-lang#82500- CDirkx:hermit-pipe, r=joshtriplett
4c3abdc
Reuse `std::sys::unsupported::pipe` on `hermit`
Pipes are not supported on `hermit` and `hermit/pipe.rs` is identical to `unsupported/pipe.rs`. This PR reduces duplication between the two by doing the following on `hermit`:
```rust
#[path = "../unsupported/pipe.rs"]
pub mod pipe;
```
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Mar 18, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 19, 2021
@Dylan-DPC
Rollup merge ofrust-lang#82500- CDirkx:hermit-pipe, r=joshtriplett
b567cd1
Reuse `std::sys::unsupported::pipe` on `hermit`
Pipes are not supported on `hermit` and `hermit/pipe.rs` is identical to `unsupported/pipe.rs`. This PR reduces duplication between the two by doing the following on `hermit`:
```rust
#[path = "../unsupported/pipe.rs"]
pub mod pipe;
```
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Mar 19, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 19, 2021
@Dylan-DPC
Rollup merge ofrust-lang#82500- CDirkx:hermit-pipe, r=joshtriplett
1a936e6
Reuse `std::sys::unsupported::pipe` on `hermit`
Pipes are not supported on `hermit` and `hermit/pipe.rs` is identical to `unsupported/pipe.rs`. This PR reduces duplication between the two by doing the following on `hermit`:
```rust
#[path = "../unsupported/pipe.rs"]
pub mod pipe;
```
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Mar 19, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 19, 2021
@JohnTitor
Rollup merge ofrust-lang#82500- CDirkx:hermit-pipe, r=joshtriplett
7a3f1a1
Reuse `std::sys::unsupported::pipe` on `hermit`
Pipes are not supported on `hermit` and `hermit/pipe.rs` is identical to `unsupported/pipe.rs`. This PR reduces duplication between the two by doing the following on `hermit`:
```rust
#[path = "../unsupported/pipe.rs"]
pub mod pipe;
```
@JohnTitorJohnTitor mentioned this pull request Mar 19, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 19, 2021
@Dylan-DPC
Rollup merge ofrust-lang#82500- CDirkx:hermit-pipe, r=joshtriplett
477e594
Reuse `std::sys::unsupported::pipe` on `hermit`
Pipes are not supported on `hermit` and `hermit/pipe.rs` is identical to `unsupported/pipe.rs`. This PR reduces duplication between the two by doing the following on `hermit`:
```rust
#[path = "../unsupported/pipe.rs"]
pub mod pipe;
```
This was referenced Mar 19, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2021
@bors
Auto merge ofrust-lang#83301- Dylan-DPC:rollup-x1yzvhm, r=Dylan-DPC
9f4bc3e
Rollup of 11 pull requests
Successful merges:
- rust-lang#82500 (Reuse `std::sys::unsupported::pipe` on `hermit`)
- rust-lang#82759 (Remove unwrap_none/expect_none from compiler/.)
- rust-lang#82846 (rustdoc: allow list syntax for #[doc(alias)] attributes)
- rust-lang#82892 (Clarify docs for Read::read's return value)
- rust-lang#83179 (Extend `proc_macro_back_compat` lint to `actix-web`)
- rust-lang#83197 (Move some test-only code to test files)
- rust-lang#83208 (Fix gitattibutes for old git versions)
- rust-lang#83215 (Deprecate std::os::haiku::raw, which accidentally wasn't deprecated)
- rust-lang#83230 (Remove unnecessary `forward_inner_docs` hack)
- rust-lang#83236 (Upgrade memmap to memmap2)
- rust-lang#83270 (Fix typo/inaccuracy in the documentation of Iterator::skip_while)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4abcd40 into rust-lang:masterMar 19, 2021
@rustbotrustbot added this to the 1.52.0 milestone Mar 19, 2021
@CDirkx
CDirkx deleted the hermit-pipe branch March 19, 2021 18:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.52.0

Development

Successfully merging this pull request may close these issues.

7 participants

@CDirkx@rust-highfive@joshtriplett@bors@JohnTitor@JohnCSimon@rustbot