Uh oh!
There was an error while loading. Please reload this page.
rustdoc: add optional woff2 versions of FiraSans. - #82545
Merged
Conversation
For browsers that support woff2 (most modern ones: https://caniuse.com/woff2), this offers a reduction in download size for these two fonts from 362k to 257k (32% reduction). It decreases the total page size for `struct.String.html` (counting all subresources) by about 2.5%. If this is interesting, I'm happy to apply the same treatment to the other fonts, but these two are the biggest.
rust-highfive
commented
Feb 26, 2021
Contributor
Some changes occurred in HTML/CSS/JS. |
rust-highfive
commented
Feb 26, 2021
Contributor
r? @jyn514 (rust-highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
commented
Feb 26, 2021
Member
That's nice, thanks! New static files, ping @rust-lang/docs-rs ! @bors: r+ rollup |
bors
commented
Feb 26, 2021
Collaborator
📌 Commit ad7ed13 has been approved by |
Nemo157
commented
Feb 26, 2021
Contributor
(just as a sanity check I confirmed these are the files from https://github.com/mozilla/Fira/releases/tag/4.202) |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 26, 2021
rustdoc: add optional woff2 versions of FiraSans. For browsers that support woff2 (most modern ones: https://caniuse.com/woff2), this offers a reduction in download size for these two fonts from 362k to 257k (32% reduction). It decreases the total page size for `struct.String.html` (counting all subresources) by about 2.5%. If this is interesting, I'm happy to apply the same treatment to the other fonts, but these two are the biggest.
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 26, 2021
rustdoc: add optional woff2 versions of FiraSans. For browsers that support woff2 (most modern ones: https://caniuse.com/woff2), this offers a reduction in download size for these two fonts from 362k to 257k (32% reduction). It decreases the total page size for `struct.String.html` (counting all subresources) by about 2.5%. If this is interesting, I'm happy to apply the same treatment to the other fonts, but these two are the biggest.
This was referenced Feb 26, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2021
…laumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#81940 (Stabilize str_split_once) - rust-lang#82165 (Reword labels on E0308 involving async fn return type) - rust-lang#82456 (Replaced some unwrap_or and map_or with lazy variants) - rust-lang#82491 (Consider inexpensive inlining criteria first) - rust-lang#82506 (Properly account for non-shorthand pattern field in unused variable lint) - rust-lang#82535 (Set codegen thread names) - rust-lang#82545 (rustdoc: add optional woff2 versions of FiraSans.) - rust-lang#82549 (Revert "Update normalize.css to 8.0.1") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 22, 2021
rustdoc: add optional woff2 versions of Source Serif and Source Code This provides woff2 versions of Source Serif and Source Code similar to how rust-lang#82545 provides woff2 versions of Fira Sans. The total byte count for the six files (three for each font family) is reduced by 25% from 476 KiB to 358 KiB.
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 22, 2021
rustdoc: add optional woff2 versions of Source Serif and Source Code This provides woff2 versions of Source Serif and Source Code similar to how rust-lang#82545 provides woff2 versions of Fira Sans. The total byte count for the six files (three for each font family) is reduced by 25% from 476 KiB to 358 KiB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For browsers that support woff2 (most modern ones:
https://caniuse.com/woff2), this offers a reduction in download size
for these two fonts from 362k to 257k (32% reduction). It decreases the
total page size for
struct.String.html(counting all subresources) byabout 2.5%.
If this is interesting, I'm happy to apply the same treatment to the
other fonts, but these two are the biggest.