Uh oh!
There was an error while loading. Please reload this page.
Prevent JS error when there is no dependency or other crate documented (or --disable-per-crate-search has been used) - #83028
Merged
bors merged 1 commit intoMar 14, 2021
Conversation
rust-highfive
commented
Mar 11, 2021
Contributor
Some changes occurred in HTML/CSS/JS. |
Contributor
It's not when there's only one crate, it's when you explicitly pass |
GuillaumeGomez
commented
Mar 13, 2021
MemberAuthor
@bors: r=Nemo157 |
bors
commented
Mar 13, 2021
Collaborator
📌 Commit 56898ec has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Mar 13, 2021
…no-filter, r=Nemo157 Prevent JS error when there is no dependency or other crate documented (or --disable-per-crate-search has been used) When there is only one crate, the dropdown is removed, creating an error (that you can see pretty easily on docs.rs for example). r? `@jyn514`
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 13, 2021
…no-filter, r=Nemo157 Prevent JS error when there is no dependency or other crate documented (or --disable-per-crate-search has been used) When there is only one crate, the dropdown is removed, creating an error (that you can see pretty easily on docs.rs for example). r? ``@jyn514``
Dylan-DPC-zz
commented
Mar 13, 2021
@bors p=1 rollup=never (Bumping this is rustdoc team needs it urgently :) |
bors
commented
Mar 14, 2021
Collaborator
⌛ Testing commit 56898ec with merge 96d67448817268496c3e50d13a6b84a9ed6264a2... |
JohnTitor
commented
Mar 14, 2021
Member
@bors retry yielding |
rust-log-analyzer
commented
Mar 14, 2021
Collaborator
bors
commented
Mar 14, 2021
Collaborator
bors
commented
Mar 14, 2021
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is only one crate, the dropdown is removed, creating an error (that you can see pretty easily on docs.rs for example).
r? @jyn514