Skip to content

stabilize debug_non_exhaustive - #83041

Merged
bors merged 3 commits into
rust-lang:masterfrom
guswynn:stable_debug_struct
Mar 25, 2021
Merged

stabilize debug_non_exhaustive#83041
bors merged 3 commits into
rust-lang:masterfrom
guswynn:stable_debug_struct

Conversation

@guswynn

@guswynnguswynn commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

tracking issue: #67364

but it is still an open question whether the other Debug* struct's should have a similar method. I would guess that would best be put underneath a new feature gate, as this one seems uncontroversial enough to stabilize as is

@rust-highfive

rust-highfive commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2021
JohnTitor
JohnTitor reviewed Mar 12, 2021
View reviewed changes
Comment threadlibrary/core/src/fmt/builders.rs Outdated
@guswynn@JohnTitor
Update library/core/src/fmt/builders.rs
b8e4981
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
@kennytm

kennytm commented Mar 12, 2021

Copy link
Copy Markdown
Member

r? @m-ou-se

@rust-highfiverust-highfive assigned m-ou-se and unassigned kennytmMar 12, 2021
@kennytmkennytm added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. T-libs-api [DEPRECATED; DO NOT USE] labels Mar 12, 2021
@m-ou-sem-ou-se mentioned this pull request Mar 13, 2021
Closed
5 tasks
@m-ou-se

m-ou-se commented Mar 13, 2021

Copy link
Copy Markdown
Member

I've started the FCP process on the tracking issue: #67364 (comment)

Marking this as blocked.

@m-ou-sem-ou-se added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2021
m-ou-se
m-ou-se reviewed Mar 24, 2021
View reviewed changes
Comment threadlibrary/core/src/fmt/builders.rs Outdated
@m-ou-se

m-ou-se commented Mar 24, 2021

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Mar 24, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit b1fac3a has been approved by m-ou-se

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 24, 2021
@JohnTitorJohnTitor mentioned this pull request Mar 25, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2021
@bors
Auto merge ofrust-lang#83454- JohnTitor:rollup-9ae0565, r=JohnTitor
26c7e55
Rollup of 8 pull requests
Successful merges:
- rust-lang#83041 (stabilize debug_non_exhaustive)
- rust-lang#83349 (Remove Option::{unwrap_none, expect_none}.)
- rust-lang#83420 (Add documentation for rustdoc-gui tests)
- rust-lang#83421 (Add Result::into_err where the Ok variant is the never type)
- rust-lang#83427 (small cleanups in rustc_errors / emitter)
- rust-lang#83434 (Update RELEASES.md)
- rust-lang#83440 (Use intra-doc link in core::cell)
- rust-lang#83442 (LLVMWrapper: attractive nuisance macros)
Failed merges:
- rust-lang#83438 (Update RELEASES.md)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a6ababb into rust-lang:masterMar 25, 2021
@rustbotrustbot added this to the 1.53.0 milestone Mar 25, 2021
@pthariensflame

pthariensflame commented Apr 10, 2021

Copy link
Copy Markdown
Contributor

relnotes?

@m-ou-sem-ou-se added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 25, 2021
@richard-uk1

richard-uk1 commented Apr 25, 2021

Copy link
Copy Markdown
Contributor

Do you want me to do some release notes? Do I just add them to RELEASES.md?

@pthariensflame

pthariensflame commented Apr 25, 2021

Copy link
Copy Markdown
Contributor

@derekdreery IIRC you shouldn’t have to do anything; the relnotes flag will be picked up by the people authoring RELEASES.md when that time comes.

@guswynn
guswynn deleted the stable_debug_struct branch September 26, 2021 18:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-ou-sem-ou-sem-ou-se left review comments
@JohnTitorJohnTitorJohnTitor left review comments

Assignees

@m-ou-sem-ou-se

Labels

needs-fcpThis change is insta-stable, or significant enough to need a team FCP to proceed.relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

9 participants

@guswynn@rust-highfive@kennytm@m-ou-se@bors@pthariensflame@richard-uk1@JohnTitor@rustbot