Uh oh!
There was an error while loading. Please reload this page.
Validate rustc_layout_scalar_valid_range_{start,end} attributes - #83054
Merged
Conversation
rust-highfive
commented
Mar 12, 2021
Contributor
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
davidtwco
approved these changes
Mar 14, 2021
davidtwco
commented
Mar 14, 2021
Member
@bors r+ |
bors
commented
Mar 14, 2021
Collaborator
📌 Commit 4943190 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 14, 2021
…ange, r=davidtwco
Validate rustc_layout_scalar_valid_range_{start,end} attributes
Fixesrust-lang#82251, rust-lang#82981.bors
commented
Mar 14, 2021
Collaborator
⌛ Testing commit 4943190 with merge e5ecd3cecf528276fc85b8a9920861154f4e8643... |
rust-log-analyzer
commented
Mar 14, 2021
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Mar 14, 2021
Collaborator
💔 Test failed - checks-actions |
JohnTitor
commented
Mar 14, 2021
Member
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 15, 2021
…ange, r=davidtwco
Validate rustc_layout_scalar_valid_range_{start,end} attributes
Fixesrust-lang#82251, fixesrust-lang#82981.Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 15, 2021
…ange, r=davidtwco
Validate rustc_layout_scalar_valid_range_{start,end} attributes
Fixesrust-lang#82251, fixesrust-lang#82981.Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 15, 2021
…ange, r=davidtwco
Validate rustc_layout_scalar_valid_range_{start,end} attributes
Fixesrust-lang#82251, fixesrust-lang#82981.bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 15, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#82989 (Custom error on literal names from other languages) - rust-lang#83054 (Validate rustc_layout_scalar_valid_range_{start,end} attributes) - rust-lang#83098 (Find more invalid doc attributes) - rust-lang#83108 (Remove unused `opt_local_def_id_to_hir_id` function) - rust-lang#83110 (Fix typos in `library/core/src/ptr/mod.rs` and `library/std/src/sys_common/thread_local_dtor.rs`) - rust-lang#83113 (Minor refactoring in try_index_step) - rust-lang#83127 (Introduce `proc_macro_back_compat` lint, and emit for `time-macros-impl`) - rust-lang#83132 (Don't encode file information for span with a dummy location) - rust-lang#83141 (:arrow_up: rust-analyzer) - rust-lang#83144 (Introduce `rustc_interface::interface::Config::parse_sess_created` callback) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 16, 2021
… r=oli-obk Use delay_span_bug instead of panic in layout_scalar_valid_range rust-lang#83054 introduced validation of scalar range attributes, but panicking code that uses the attribute remained reachable. Use `delay_span_bug` instead to avoid the ICE. Fixesrust-lang#83180.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#82251, fixes#82981.