Uh oh!
There was an error while loading. Please reload this page.
Enable -W semicolon_in_expressions_from_macros in bootstrap - #83089
Merged
Conversation
rust-highfive
commented
Mar 13, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
commented
Mar 13, 2021
Member
r=me in theory but looks like there's at least one use left |
Aaron1011 added a commit
to Aaron1011/stdarch
that referenced
this pull request
Mar 13, 2021
Amanieu pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Mar 13, 2021
Aaron1011
commented
Mar 15, 2021
ContributorAuthor
This is now blocked on bumping the |
jyn514
commented
Apr 16, 2021
Member
@Aaron1011 this should be possible since #83776 |
This comment has been minimized.
This comment has been minimized.
Aaron1011
commented
Apr 16, 2021
ContributorAuthor
It looks like rust-lang/stdarch#1080 wasn't included in the submodule bump. |
This comment has been minimized.
This comment has been minimized.
Now that stdarch has been updated, we can do this without breaking the build.
Aaron1011
commented
May 8, 2021
ContributorAuthor
@Mark-Simulacrum This is now ready to merge |
Mark-Simulacrum
commented
May 8, 2021
Member
@bors r+ |
bors
commented
May 8, 2021
Collaborator
📌 Commit 020d83d has been approved by |
bors
commented
May 8, 2021
Collaborator
bors
commented
May 9, 2021
Collaborator
☀️ Test successful - checks-actions |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that stdarch has been updated, we can do this without breaking the
build.