Skip to content

Simplify Command::spawn (no semantic change) - #83170

Merged
bors merged 1 commit into
rust-lang:masterfrom
joshtriplett:spawn-cleanup
Mar 30, 2021
Merged

Simplify Command::spawn (no semantic change)#83170
bors merged 1 commit into
rust-lang:masterfrom
joshtriplett:spawn-cleanup

Conversation

@joshtriplett

@joshtriplettjoshtriplett commented Mar 15, 2021

Copy link
Copy Markdown
Member

This minimizes the size of an unsafe block, and allows outdenting some
complex code.

@rust-highfive

rust-highfive commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2021
@joshtriplett

joshtriplett commented Mar 15, 2021

Copy link
Copy Markdown
MemberAuthor

Note that I based this PR on the branch from #83121 , to avoid a conflict.

@kennytm

kennytm commented Mar 17, 2021

Copy link
Copy Markdown
Member

CI not running? 🤔

@kennytmkennytm closed this Mar 17, 2021
@kennytmkennytm reopened this Mar 17, 2021
@joshtriplett

joshtriplett commented Mar 18, 2021

Copy link
Copy Markdown
MemberAuthor

I'd like to hold off on this one until #81825 gets in, since the two will likely conflict and that one has been waiting longer. I'll rebase this after that goes in.

@kennytmkennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2021
@voidc

voidc commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

I also don't mind rebasing #81825 if you want to merge this first.

@joshtriplett

joshtriplett commented Mar 20, 2021

Copy link
Copy Markdown
MemberAuthor

@voidc I appreciate that, but this is a minor cleanup and I'm much more interested in the pidfd work.

@joshtriplett
Simplify Command::spawn (no semantic change)
68dbdfb
This minimizes the size of an unsafe block, and allows outdenting some
complex code.
@joshtriplett

joshtriplett commented Mar 29, 2021

Copy link
Copy Markdown
MemberAuthor

Since #81825 seems to be blocked by an LLVM codegen issue, I'd like to go ahead and merge this.

@joshtriplettjoshtriplett added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 29, 2021
@joshtriplett

joshtriplett commented Mar 29, 2021

Copy link
Copy Markdown
MemberAuthor

@kennytm

@kennytm

kennytm commented Mar 30, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Mar 30, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 68dbdfb has been approved by kennytm

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2021
@bors

bors commented Mar 30, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 68dbdfb with merge 7b6fc5a...

@bors

bors commented Mar 30, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: kennytm
Pushing 7b6fc5a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Mar 30, 2021
@bors
bors merged commit 7b6fc5a into rust-lang:masterMar 30, 2021
@rustbotrustbot added this to the 1.53.0 milestone Mar 30, 2021
This was referenced Mar 30, 2021
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kennytmkennytm

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

6 participants

@joshtriplett@rust-highfive@kennytm@voidc@bors@rustbot