Skip to content

use checkout@v2 in CI for master - #83201

Merged
bors merged 1 commit into
rust-lang:masterfrom
klensy:checkout-v2
Mar 19, 2021
Merged

use checkout@v2 in CI for master#83201
bors merged 1 commit into
rust-lang:masterfrom
klensy:checkout-v2

Conversation

@klensy

Copy link
Copy Markdown
Contributor

Updates CI workflow to use checkout@v2 from v1 (as other parts of CI) for master, plus slightly faster checkout as result
compare v2
https://github.com/rust-lang-ci/rust/commit/2ccf06302c08d7d4911aad40e66a9a3ee731c6f9/checks/2113902859/logs
and v1 logs
https://github.com/rust-lang-ci/rust/commit/2ccf06302c08d7d4911aad40e66a9a3ee731c6f9/checks/2115229351/logs

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2021
@klensy

Copy link
Copy Markdown
ContributorAuthor

Btw, github migrate (or already migrated?) runner ubuntu-latest from ubuntu-18.04 to ubuntu-20.04, it won't break parts of CI?

Those two logs linked, one with 18.04, and other one with 20.04.

@jyn514jyn514 added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Mar 16, 2021
@klensy

Copy link
Copy Markdown
ContributorAuthor

ubuntu-latest switched to 20.04actions/runner-images#1816

@emilyalbini

Copy link
Copy Markdown
Member

Thanks!
@bors r+

Btw, github migrate (or already migrated?) runner ubuntu-latest from ubuntu-18.04 to ubuntu-20.04, it won't break parts of CI?

Our main runners are not using the standard ubuntu-latest, we're running on a custom image.

@bors

bors commented Mar 18, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 22f2548 has been approved by pietroalbini

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 19, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 19, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 19, 2021
@JohnTitorJohnTitor mentioned this pull request Mar 19, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 19, 2021
@Dylan-DPC-zz

Copy link
Copy Markdown

@bors rollup=never (might interfere with other prs)

@bors

bors commented Mar 19, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 22f2548 with merge f5f33ec...

@bors

bors commented Mar 19, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing f5f33ec to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Mar 19, 2021
@bors
bors merged commit f5f33ec into rust-lang:masterMar 19, 2021
@rustbotrustbot added this to the 1.52.0 milestone Mar 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@klensy@rust-highfive@emilyalbini@bors@Dylan-DPC-zz@jyn514@rustbot