Uh oh!
There was an error while loading. Please reload this page.
Mark early otherwise optimization unsound - #83277
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
spastorinoforce-pushed
the
early_otherwise-opt-unsound
branch
from
March 18, 2021 23:57
a39b294 to
778e197Comparespastorino
marked this pull request as ready for review
March 18, 2021 23:58
oli-obk
commented
Mar 19, 2021
Contributor
level 3 is the right level for this, as its unsoundness is not relevant for the level. |
oli-obk
commented
Mar 19, 2021
Contributor
@bors r+ rollup |
bors
commented
Mar 19, 2021
Collaborator
📌 Commit 778e197 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#79986 (Only build help popup when it's really needed) - rust-lang#82570 (Add `as_str` method for split whitespace str iterators) - rust-lang#83244 (Fix overflowing length in Vec<ZST> to VecDeque) - rust-lang#83254 (Include output stream in `panic!()` documentation) - rust-lang#83269 (Revert the second deprecation of collections::Bound) - rust-lang#83277 (Mark early otherwise optimization unsound) - rust-lang#83285 (Update LLVM to bring in SIMD updates for WebAssembly) - rust-lang#83297 (Do not ICE on ty::Error as an error must already have been reported) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
cc @tmiasko
Related to #78496 and #82905
Should I also bump this one to level 3 or 4 or given that is unsound it doesn't matter?.
Probably need to adjust some tests.