Skip to content

Make # pretty print format easier to discover - #83388

Merged
bors merged 2 commits into
rust-lang:masterfrom
alamb:alamb/fmt-dcs
Mar 27, 2021
Merged

Make # pretty print format easier to discover#83388
bors merged 2 commits into
rust-lang:masterfrom
alamb:alamb/fmt-dcs

Conversation

@alamb

@alambalamb commented Mar 22, 2021

Copy link
Copy Markdown
Contributor

Rationale:

I use (cargo cult?) three formats in rust: {}, debug {:?}, and pretty-print debug {:#?}. I discovered {:#?} in some blog post or guide when I started working in Rust. While # is documented I think it is hard to discover. So taking the good advice of @carols10cents I am trying to improve the docs with a PR

As a reminder "pretty print" means that where {:?} will print something like

foo: { b1: 1, b2: 2}

{:#?} will prints something like

foo {
b1: 1
b2: 3
}

Changes

Add an example to fmt to try and make it easier to discover #

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2021
Comment threadlibrary/alloc/src/fmt.rs Outdated
@alambalamb changed the title Make # format easier to discoverMake # pretty print format easier to discoverMar 23, 2021
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Mar 26, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 93737dc has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 26, 2021
Make # pretty print format easier to discover
# Rationale:
I use (cargo cult?) three formats in rust: `{}`, debug `{:?}`, and pretty-print debug `{:#?}`. I discovered `{:#?}` in some blog post or guide when I started working in Rust. While `#` is documented I think it is hard to discover. So taking the good advice of `@carols10cents` I am trying to improve the docs with a PR
As a reminder "pretty print" means that where `{:?}` will print something like
```
foo: { b1: 1, b2: 2}
```
`{:#?}` will prints something like
```
foo {
b1: 1
b2: 3
}
```
# Changes
Add an example to `fmt` to try and make it easier to discover `#`
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 27, 2021
Make # pretty print format easier to discover
# Rationale:
I use (cargo cult?) three formats in rust: `{}`, debug `{:?}`, and pretty-print debug `{:#?}`. I discovered `{:#?}` in some blog post or guide when I started working in Rust. While `#` is documented I think it is hard to discover. So taking the good advice of ``@carols10cents`` I am trying to improve the docs with a PR
As a reminder "pretty print" means that where `{:?}` will print something like
```
foo: { b1: 1, b2: 2}
```
`{:#?}` will prints something like
```
foo {
b1: 1
b2: 3
}
```
# Changes
Add an example to `fmt` to try and make it easier to discover `#`
@JohnTitorJohnTitor mentioned this pull request Mar 27, 2021
@JohnTitorJohnTitor mentioned this pull request Mar 27, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2021
Rollup of 9 pull requests
Successful merges:
- rust-lang#83239 (Remove/replace some outdated crates from the dependency tree)
- rust-lang#83328 (Fixes to inline assmebly tests)
- rust-lang#83343 (Simplify and fix byte skipping in format! string parser)
- rust-lang#83388 (Make # pretty print format easier to discover)
- rust-lang#83431 (Tell GitHub to highlight `config.toml.example` as TOML)
- rust-lang#83508 (Use the direct link to the platform support page)
- rust-lang#83511 (compiletest: handle llvm_version with suffix like "12.0.0libcxx")
- rust-lang#83524 (Document that the SocketAddr memory representation is not stable)
- rust-lang#83525 (fix doc comment for `ty::Dynamic`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit c143267 into rust-lang:masterMar 27, 2021
@rustbotrustbot added this to the 1.53.0 milestone Mar 27, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@alamb@rust-highfive@Mark-Simulacrum@bors@camelid@rustbot