Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #83503
Merged
Merged
Conversation
Looks like I missed the lack of these "and"s. Acked-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Which thus missed the point of the change: `rustdoc` already bundled documentation for methods accessible through one layer of `Deref`, it now has been enhanced to keep recursing 🙂
Fixesrust-lang#83469 We need to return an `Annotatable::Stmt` if we were passed an `Annotatable::Stmt`
…doc, r=jyn514 [rustdoc] Don't document stripped items in JSON renderer. Fixesrust-lang#80664, see [my comment there](rust-lang#80664 (comment)) for why Note that we already do something similar in `convert_item`: https://github.com/rust-lang/rust/blob/bb4cdf8ec034dca5c056ec9295f38062e5b7e871/src/librustdoc/json/conversions.rs#L28-L31 ``@rustbot`` modify labels: +T-rustdoc +A-rustdoc-json r? ``@jyn514`` cc ``@CraftSpider``
Refactor rust-lang#82270 as lint instead of an error This PR fixes several issues with rust-lang#82270 which generated an error when `.intel_syntax` or `.att_syntax` was used in inline assembly: - It is now a warn-by-default lint instead of an error. - The lint only triggers on x86. `.intel_syntax` and `.att_syntax` are only valid on x86. - The lint no longer provides machine-applicable suggestions for two reasons: - These changes should not be made automatically since changes to assembly code can be very subtle. - The template string is not always just a string: it can contain macro invocation (`concat!`), raw strings, escape characters, etc. cc ``@asquared31415``
…ietroalbini Fix bootstrap tests on beta Forward-porting a fix from the beta branch, which led to test failure on beta. r? ``@pietroalbini``
Add docs for Vec::from functions Part of rust-lang#51430
… r=kennytm ExitStatusExt: Fix missing word in two docs messages Looks like I missed the lack of these "and"s.
Fix patch note about rust-lang#80653 not mentioning nested nor recursive Which thus missed the point of the change: `rustdoc` already bundled documentation for methods accessible through one layer of `Deref`, it has now been enhanced to keep recursing 🙂 r? ``@jyn514``
Mark asm tests as requiring LLVM 10.0.1
…=petrochenkov Don't ICE when using `#[global_alloc]` on a non-item statement Fixesrust-lang#83469 We need to return an `Annotatable::Stmt` if we were passed an `Annotatable::Stmt`
Dylan-DPC-zz
commented
Mar 26, 2021
Author
@bors r+ rollup=never p=5 |
bors
commented
Mar 26, 2021
Collaborator
📌 Commit b0bec95 has been approved by |
bors
commented
Mar 26, 2021
Collaborator
bors
commented
Mar 26, 2021
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
asm!#82270 as lint instead of an error)Dereftraits #80653 not mentioning nested nor recursive)#[global_alloc]on a non-item statement #83486 (Don't ICE when using#[global_alloc]on a non-item statement)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup