Skip to content

give full path of constraint in suggest_constraining_type_param - #83673

Merged
bors merged 1 commit into
rust-lang:masterfrom
0xPoe:rustin-patch-suggestion
Apr 2, 2021
Merged

give full path of constraint in suggest_constraining_type_param#83673
bors merged 1 commit into
rust-lang:masterfrom
0xPoe:rustin-patch-suggestion

Conversation

@0xPoe

@0xPoe0xPoe commented Mar 30, 2021

Copy link
Copy Markdown
Member

close#83513

@rust-highfive

rust-highfive commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2021
@lcnr

lcnr commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

r? @estebank

feeling unsure about whether using full paths is actually desirable, but don't have a strong opinion here

@rust-highfiverust-highfive assigned estebank and unassigned lcnrMar 30, 2021
@0xPoe
0xPoeforce-pushed the rustin-patch-suggestion branch 2 times, most recently from 6f74059 to 1f3d049CompareMarch 30, 2021 11:23
@estebank

estebank commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

Oh! It's a shame that it also affects things in the prelude 🤔

The current behavior means you get two errors but if you apply both suggestions you get to working code. The new behavior means a single step to working code, at the cost of verbosity.

@lcnr what do you think about this: lets land this (to reduce fix cycles for users) and revisit this output once we have real "locally accessible paths" for these suggestions where we can reduce the verbosity again.

@lcnr

lcnr commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

what do you think about this: lets land this (to reduce fix cycles for users) and revisit this output once we have real "locally accessible paths" for these suggestions where we can reduce the verbosity again.

👍

@estebank

estebank commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 30, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 1f3d049 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 30, 2021
@Dylan-DPC
Rollup merge ofrust-lang#83673- hi-rustin:rustin-patch-suggestion, …
51fa639
…r=estebank
give full path of constraint in suggest_constraining_type_param
closerust-lang#83513
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Mar 30, 2021
Closed
@Dylan-DPC-zz

Dylan-DPC-zz commented Mar 30, 2021

Copy link
Copy Markdown

failed in rollup

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 30, 2021
@0xPoe
0xPoeforce-pushed the rustin-patch-suggestion branch from 1f3d049 to 316e4eeCompareMarch 31, 2021 00:31
@0xPoe
0xPoeforce-pushed the rustin-patch-suggestion branch from 316e4ee to 8f77356CompareMarch 31, 2021 01:47
@0xPoe

0xPoe commented Mar 31, 2021

Copy link
Copy Markdown
MemberAuthor

failed in rollup

@bors r-

failed in rollup

@bors r-

@Dylan-DPC Blessed with nll compare mode.

@0xPoe

0xPoe commented Mar 31, 2021

Copy link
Copy Markdown
MemberAuthor

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 31, 2021
@Dylan-DPC-zz

Dylan-DPC-zz commented Mar 31, 2021

Copy link
Copy Markdown

@bors r=estebank

@bors

bors commented Mar 31, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 8f77356 has been approved by estebank

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2021
@rust-log-analyzer

rust-log-analyzer commented Mar 31, 2021

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 31, 2021
@Dylan-DPC
Rollup merge ofrust-lang#83673- hi-rustin:rustin-patch-suggestion, …
918166e
…r=estebank
give full path of constraint in suggest_constraining_type_param
closerust-lang#83513
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Mar 31, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 31, 2021
@Dylan-DPC
Rollup merge ofrust-lang#83673- hi-rustin:rustin-patch-suggestion, …
cb59053
…r=estebank
give full path of constraint in suggest_constraining_type_param
closerust-lang#83513
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Mar 31, 2021
Closed
@Dylan-DPC-zz

Dylan-DPC-zz commented Mar 31, 2021

Copy link
Copy Markdown

failed in rollup

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 31, 2021
@0xPoe

0xPoe commented Apr 1, 2021

Copy link
Copy Markdown
MemberAuthor

failed in rollup

@bors r-

@Dylan-DPC I tested both modes again locally with no problems, so I don't know what's wrong, do you have any suggestions?

image

@0xPoe

0xPoe commented Apr 1, 2021

Copy link
Copy Markdown
MemberAuthor

It seems that without my commit, this #83728 PR is also failing because of the same problem?

@0xPoe

0xPoe commented Apr 1, 2021

Copy link
Copy Markdown
MemberAuthor

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2021
@Dylan-DPC-zz

Dylan-DPC-zz commented Apr 1, 2021

Copy link
Copy Markdown

let's give it a try once,

@bors r=estebank

@bors

bors commented Apr 1, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 8f77356 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2021
@0xPoe

0xPoe commented Apr 1, 2021

Copy link
Copy Markdown
MemberAuthor

let's give it a try once,

Thanks, maybe we can rollup this time without the other PRs that modify the diagnostic information, otherwise it might fail again and we still don't know if the PR is the problem.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 1, 2021
@Dylan-DPC
Rollup merge ofrust-lang#83673- hi-rustin:rustin-patch-suggestion, …
3a7479d
…r=estebank
give full path of constraint in suggest_constraining_type_param
closerust-lang#83513
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 1, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 2, 2021
@Dylan-DPC
Rollup merge ofrust-lang#83673- hi-rustin:rustin-patch-suggestion, …
0c4b370
…r=estebank
give full path of constraint in suggest_constraining_type_param
closerust-lang#83513
This was referenced Apr 2, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2021
@bors
Auto merge ofrust-lang#83790- Dylan-DPC:rollup-p6ep8jo, r=Dylan-DPC
138fd56
Rollup of 7 pull requests
Successful merges:
- rust-lang#83065 (Rework `std::sys::windows::alloc`)
- rust-lang#83478 (rustdoc: Add unstable option to only emit shared/crate-specific files)
- rust-lang#83629 (Fix double-drop in `Vec::from_iter(vec.into_iter())` specialization when items drop during panic)
- rust-lang#83673 (give full path of constraint in suggest_constraining_type_param)
- rust-lang#83755 (Simplify coverage tests)
- rust-lang#83757 (2229: Support migration via rustfix)
- rust-lang#83771 (Fix stack overflow detection on FreeBSD 11.1+)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 6cb74ad into rust-lang:masterApr 2, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 2, 2021
@0xPoe
0xPoe deleted the rustin-patch-suggestion branch April 3, 2021 03:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebankestebank

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

Error message doesn't give full path in suggestion.

8 participants

@0xPoe@rust-highfive@lcnr@estebank@bors@Dylan-DPC-zz@rust-log-analyzer@rustbot