Skip to content

add fp-armv8 for ARM_ALLOWED_FEATURES - #83803

Merged
bors merged 1 commit into
rust-lang:masterfrom
surechen:add_target_feature
Apr 4, 2021
Merged

add fp-armv8 for ARM_ALLOWED_FEATURES#83803
bors merged 1 commit into
rust-lang:masterfrom
surechen:add_target_feature

Conversation

@surechen

@surechensurechen commented Apr 3, 2021

Copy link
Copy Markdown
Contributor

For fixing err in rust-lang/stdarch#1105.

@rust-highfive

rust-highfive commented Apr 3, 2021

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 3, 2021
@petrochenkov

petrochenkov commented Apr 3, 2021

Copy link
Copy Markdown
Contributor

@Amanieu
The analogous feature for aarch64 is called just "fp" and it's translated to "fp-armv8" by fn to_llvm_feature.
I'm not sure whether aarch32 should follow aarch64 here or use the LLVM naming "fp-armv8" directly.

@petrochenkovpetrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2021
@Amanieu

Amanieu commented Apr 3, 2021

Copy link
Copy Markdown
Member

On AArch64, fp-armv8 refers to the entire set of FP instructions. However on ARM, fp-armv8 only refers to the FP instructions that were added in ARMv8, which builds on top of the VFP instructions.

I think it's fine to leave it as fp-armv8 for now. We should definitely revisit the feature names when we eventually get around to stabilizing them.

@petrochenkov

petrochenkov commented Apr 3, 2021

Copy link
Copy Markdown
Contributor

Ok.
@bors r+ rollup

@bors

bors commented Apr 3, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 944b53e has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2021
@JohnTitorJohnTitor mentioned this pull request Apr 3, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2021
@bors
Auto merge ofrust-lang#83811- JohnTitor:rollup-hnw1xwz, r=JohnTitor
2616ab1
Rollup of 7 pull requests
Successful merges:
- rust-lang#82487 (Constify methods of `std::net::SocketAddr`, `SocketAddrV4` and `SocketAddrV6`)
- rust-lang#83756 (rustdoc: Rename internal uses of `spotlight`)
- rust-lang#83780 (Document "standard" conventions for error messages)
- rust-lang#83787 (Monomorphization doc fix)
- rust-lang#83803 (add fp-armv8 for ARM_ALLOWED_FEATURES)
- rust-lang#83804 (Remove nightly features in rustc_type_ir)
- rust-lang#83810 (Fix rustc_lint_defs documentation typo)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d0266e3 into rust-lang:masterApr 4, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

6 participants

@surechen@rust-highfive@petrochenkov@Amanieu@bors@rustbot