Uh oh!
There was an error while loading. Please reload this page.
Check for asm support in UI tests that require it - #84099
Conversation
rust-highfive
commented
Apr 11, 2021
(rust-highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Apr 11, 2021
Hm, I wonder if we should avoid limiting to just x86_64 - regardless, I would like to see the comment annotated with why we're requiring that target/platform. r? @Amanieu |
tmiasko
commented
Apr 11, 2021
We could add |
Amanieu
commented
Apr 11, 2021
All the other asm tests do this. The main reason is that, although the specific functionality that is being tested is not arch-specific, we still need to pick an architecture that supports For simplicity we only run the tests on x86_64 to ensure they are tested by CI. The arch-specific parts of |
Mark-Simulacrum
commented
Apr 11, 2021
Makes sense, OK. I think comments or using something like needs-asm-support would be good, but not necessarily blockers. |
6fd4c7d to
5e87f97CompareAmanieu
commented
Apr 12, 2021
@bors r+ |
bors
commented
Apr 12, 2021
📌 Commit 5e87f97 has been approved by |
Check for asm support in UI tests that require it Add `needs-asm-support` compiletest directive, and use it in asm tests that require asm support without relying on any architecture specific features. Closesrust-lang#84038.
Dylan-DPC-zz
commented
Apr 12, 2021
Add `needs-asm-support` compiletest directive, and use it in asm tests that require asm support without relying on any architecture specific features.
Amanieu
commented
Apr 13, 2021
@bors r+ |
bors
commented
Apr 13, 2021
📌 Commit da40e69 has been approved by |
bors
commented
Apr 13, 2021
bors
commented
Apr 13, 2021
☀️ Test successful - checks-actions |
Add
needs-asm-supportcompiletest directive, and use it in asm teststhat require asm support without relying on any architecture specific
features.
Closes#84038.